add OMP SGD to speedup with CPUs #4363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luotao1
reviewed
Sep 25, 2017
Contributor
luotao1
left a comment
luotao1
left a comment
There was a problem hiding this comment.
有一个疑问：既然已经在sgdUpdateCpu函数里加了
#ifdef PADDLE_USE_MKLDNN
#pragma omp parallel for
#endif
为什么还要一个单独的sgdUpdateWithOMP呢？
Contributor
Author
|
两者函数申明不一样，不过确实是可以想办法综合下，是有点重复。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When run benchmark, it spends much time on updating parameters.
This time can be improved with the OpenMP when enabled
WITH_MKLDNN.This PR adds the implement for SGD updater.