Add helper function in GradOpDescMakerBase. Make it easier to use. #4551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reyoung
changed the title
JiayiFeng
reviewed
Oct 3, 2017
paddle/framework/op_info.h
Outdated
| OpCreator creator_; | ||
| std::string grad_op_type_; | ||
| GradOpDescMakerBase* grad_op_maker_{nullptr}; | ||
| std::function<std::vector<OpDescBind>(const OpDescBind&)> grad_op_maker_; |
Collaborator
There was a problem hiding this comment.
grad_op_maker_ returns std::vector<OpDescBind>, while in BlockDescBind ops_ is std::deque<std::unique_ptr<OpDescBind>>. So when and how shall we convert OpDescBind to std::unique_ptr<OpDescBind>?
Collaborator
Author
There was a problem hiding this comment.
Yes. You are right. grad_op_maker_ should return vector<unique_ptr<OpDescBind>>.
JiayiFeng
previously approved these changes
Oct 3, 2017
Collaborator
JiayiFeng
left a comment
JiayiFeng
left a comment
There was a problem hiding this comment.
LGTM, thank you for updating the design doc!
JiayiFeng
approved these changes
Oct 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.