Feature/tensor array add python binding #4616
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/tensor_array_add_python_binding
…/tensor_array_add_python_binding
Superjomn
requested review from
jacquesqiao,
qingqing01 and
tonyyang-svail
and removed request for
qingqing01
jacquesqiao
reviewed
Oct 6, 2017
paddle/pybind/pybind.cc
Outdated
| .def("size", [](TensorArray &self) { return self.size(); }) | ||
| .def("pack", | ||
| [](TensorArray &self, size_t level, | ||
| std::vector<std::vector<size_t>> &meta_info, |
wangkuiyi
previously approved these changes
Oct 6, 2017
Collaborator
wangkuiyi
left a comment
wangkuiyi
left a comment
There was a problem hiding this comment.
Should we move the binding out from pybind.cc to another file in the same directory?
Contributor
Author
|
You mean to split the pybind.cc to multiple files? @wangkuiyi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves: #4608