Skip to content

Fix flushing vars #4640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JiayiFeng merged 1 commit into from
Oct 9, 2017
Merged

Fix flushing vars #4640

JiayiFeng merged 1 commit into from
Oct 9, 2017

Conversation

@JiayiFeng
Copy link
Collaborator

@JiayiFeng JiayiFeng commented Oct 9, 2017

fixes #4624

@JiayiFeng JiayiFeng changed the title Fix flush vars Fix flushing vars Oct 9, 2017
reyoung
reyoung approved these changes Oct 9, 2017
View reviewed changes
Copy link
Collaborator

@reyoung reyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@JiayiFeng JiayiFeng merged commit 0ff540c into PaddlePaddle:develop Oct 9, 2017
@JiayiFeng JiayiFeng deleted the fix_flush_var branch October 9, 2017 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@reyoung reyoung reyoung approved these changes

@tonyyang-svail tonyyang-svail Awaiting requested review from tonyyang-svail

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Need to flush vars_ in BlockDescBind::Sync()

2 participants

@JiayiFeng @reyoung