Unify CUDA stream in Tensor CopyFrom interface #4692
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QiJune
requested review from
Superjomn,
guoshengCS,
hedaoyuan,
luotao1,
qingqing01 and
reyoung
QiJune
changed the title
QiJune
force-pushed
the
unify_copy_interface
branch
from
dd1023c to
e162c74
Compare
wangkuiyi
previously approved these changes
Oct 11, 2017
paddle/framework/tensor.h
Outdated
| * @param[in] src The external vector. | ||
| * @param[in] ctx The device context contains place where to store. | ||
| * @param[in] src The external tensor. | ||
| * @param[in] ctx The device context contains CUDA stream. |
Collaborator
There was a problem hiding this comment.
Suppose that we need to copy from GPU to CPU, what kind of DeviceContext here do we need -- CPUContext or CUDAContext? What if the reverse order -- from GPU to CPU? What if between CPU and FPGA?
Member
Author
There was a problem hiding this comment.
When we make Copy between devices, we have to pass a DeviceContext which contains device resources. In GPU, the device resource is CUDA stream. Copying from GPU to CPU, CPU to GPU and GPU to GPU all need a CUDA stream.
wangkuiyi
previously approved these changes
Oct 11, 2017
wangkuiyi
approved these changes
Oct 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3796
Unify CUDA stream in Tensor CopyFrom interface.