Skip to content

enforce shape of backward target to be {1} #5745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jacquesqiao merged 7 commits into from
Nov 18, 2017
Merged

enforce shape of backward target to be {1} #5745

jacquesqiao merged 7 commits into from
Nov 18, 2017

Conversation

@jacquesqiao
Copy link
Member

@jacquesqiao jacquesqiao commented Nov 17, 2017 •
edited
Loading

fix: #5746

abhinavarora
abhinavarora previously approved these changes Nov 17, 2017
View reviewed changes
Copy link
Contributor

@abhinavarora abhinavarora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

abhinavarora
abhinavarora approved these changes Nov 18, 2017
View reviewed changes
Copy link
Contributor

@abhinavarora abhinavarora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jacquesqiao jacquesqiao merged commit 569f7c4 into PaddlePaddle:develop Nov 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@reyoung reyoung Awaiting requested review from reyoung

1 more reviewer

@abhinavarora abhinavarora abhinavarora approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

the target of backward should always have shape {1}

2 participants

@jacquesqiao @abhinavarora