"add registry interface" #6449
Merged
"add registry interface" #6449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typhoonzero
previously approved these changes
Dec 11, 2017
Contributor
typhoonzero
left a comment
typhoonzero
left a comment
There was a problem hiding this comment.
LGTM and a minor comment.
python/paddle/v2/fluid/layers.py
Outdated
| layer_registry('scale') | ||
| layer_registry('reshape') | ||
| layer_registry('transpose') | ||
| layer_registry('sigmoid_cross_entropy_with_logits') |
Contributor
There was a problem hiding this comment.
The name should be register_layer, it's more meaningful.
reyoung
reviewed
Dec 11, 2017
| 'StaticRNN', 'cast', 'sequence_conv', 'sequence_pool', 'sums', 'cos_sim', | ||
| 'batch_norm', 'accuracy', 'split_lod_tensor', 'While' | ||
| ] | ||
|
|
Collaborator
There was a problem hiding this comment.
Maybe we can create an array here.
_layer_op_array_ = ['mean', 'mul', ...]
for _each_ in _layer_op_array_:
register_layer(_each_)
reyoung
approved these changes
Dec 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #6448