Skip to content

Conversation

@QiJune
Copy link
Member

@QiJune QiJune commented Dec 13, 2017

Fix #6576

Copy link
Contributor

@abhinavarora abhinavarora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
There are some portions where the language in the documentation needs to be polished. I am approving this PR and then I can begin a new PR that polishes the language and the grammar.

@abhinavarora abhinavarora merged commit fd12776 into PaddlePaddle:develop Dec 13, 2017
@helinwang
Copy link
Contributor

Very informative, thank you @QiJune !

Curious what does groups do in:

template <typename DeviceContext, typename T>
class MaxOutFunctor {
 public:
  void operator()(const DeviceContext& context, const framework::Tensor& input,
                  framework::Tensor* output, int groups);
};

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants