Skip to content

auto set openblas env #7104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
luotao1 merged 3 commits into from
Dec 29, 2017
Merged

auto set openblas env #7104

luotao1 merged 3 commits into from
Dec 29, 2017

Conversation

@tensor-tang
Copy link
Contributor

@tensor-tang tensor-tang commented Dec 28, 2017 •
edited by luotao1
Loading

fix #7105

@tensor-tang tensor-tang requested a review from luotao1 December 28, 2017 14:18
luotao1
luotao1 reviewed Dec 29, 2017
View reviewed changes
Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

run_openblas_infer.sh脚本也要对应做修改

benchmark/paddle/image/run_openblas_train.sh Outdated
set -e

function train() {
unset OMP_NUM_THREADS MKL_NUM_THREADS OMP_DYNAMIC KMP_AFFINITY
Copy link
Contributor

@luotao1 luotao1 Dec 29, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

第4行的unset要变么，OMP_NUM_THREADS 和MKL_NUM_THREADS应该对openblas没有作用吧。

Copy link
Contributor Author

@tensor-tang tensor-tang Dec 29, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是没有作用的，可以删掉。

tensor-tang
tensor-tang commented Dec 29, 2017
View reviewed changes
Copy link
Contributor Author

@tensor-tang tensor-tang left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好的没问题, Done.

benchmark/paddle/image/run_openblas_train.sh Outdated
set -e

function train() {
unset OMP_NUM_THREADS MKL_NUM_THREADS OMP_DYNAMIC KMP_AFFINITY
Copy link
Contributor Author

@tensor-tang tensor-tang Dec 29, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是没有作用的，可以删掉。

@luotao1 luotao1 mentioned this pull request Dec 29, 2017
Closed
luotao1
luotao1 approved these changes Dec 29, 2017
View reviewed changes
Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit d00e1ed into PaddlePaddle:develop Dec 29, 2017
@tensor-tang tensor-tang deleted the openblas branch December 29, 2017 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@luotao1 luotao1 luotao1 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Lack of openblas env

2 participants

@tensor-tang @luotao1