Skip to content

Conversation

@pkuyym
Copy link
Contributor

@pkuyym pkuyym commented Jan 2, 2018

Resolves #7024

@pkuyym pkuyym requested a review from JiayiFeng January 2, 2018 04:52
"""
This function creates an operator for creating a LOD_RANK_TABLE
using the input x.
"""LoD Rank Table Operator. Given an input variable `x` and a LoD level,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LoD level ==> number of Lod level

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

using the input x.
"""LoD Rank Table Operator. Given an input variable `x` and a LoD level,
this layer creates a LodRankTable object. A LoDRankTable object contains a
list of bi-element tuples and each tuple consists of an index and a length.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

each tuple consists of an index and a length, both of them are int.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

"""LoD Rank Table Operator. Given an input variable `x` and a LoD level,
this layer creates a LodRankTable object. A LoDRankTable object contains a
list of bi-element tuples and each tuple consists of an index and a length.
For given level's LoD information, the index is the sequence position and
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not easy to understand what is level's LoD information.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Args:
x (Variable): Input variable, a LoDTensor based which to create the lod
rank table.
level (int): Specify the LoD level.
Copy link
Collaborator

@JiayiFeng JiayiFeng Jan 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Specify on which LoD level create the LoDRankTable object.

Copy link
Collaborator

@JiayiFeng JiayiFeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pkuyym pkuyym merged commit 9cfa5ce into PaddlePaddle:develop Jan 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants