Skip to content

Conversation

@pkuyym
Copy link
Contributor

@pkuyym pkuyym commented Jan 3, 2018

Resolves #7156

@pkuyym pkuyym requested a review from qingqing01 January 3, 2018 06:14
@qingqing01 qingqing01 requested a review from sidgoyal78 January 3, 2018 06:18
Copy link
Contributor

@sidgoyal78 sidgoyal78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Looks good. Just a minor clarification: Since, we aren't dealing with the W_{xc} c_{t-1} (where x = i and o), the current implementation is a minor variant (with no peephole connections) of the more general LSTM right?

@pkuyym
Copy link
Contributor Author

pkuyym commented Jan 3, 2018

@sidgoyal78
Yes, you are right, implementation of lstm_unit mainly refers caffe2, and peephole is not supported.
https://github.com/caffe2/caffe2/blob/master/caffe2/operators/lstm_unit_op.h#L1

sidgoyal78
sidgoyal78 previously approved these changes Jan 3, 2018
Copy link
Contributor

@sidgoyal78 sidgoyal78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sidgoyal78
Copy link
Contributor

Oops, as you might have seen already, i think the build failed.

@pkuyym
Copy link
Contributor Author

pkuyym commented Jan 3, 2018

Thanks. An random failure, will restart CI ASAP.

@sidgoyal78
Copy link
Contributor

sidgoyal78 commented Jan 3, 2018

@pkuyym : Actually, it is not random. I think this line needs to be corrected:https://github.com/PaddlePaddle/Paddle/blob/develop/python/paddle/v2/fluid/tests/test_layers.py?utf8=%E2%9C%93#L180 and L181
Since we want second dim of prev_hidden and prev_cell to be same, and they are not same here!

@sidgoyal78
Copy link
Contributor

No worries, I think I should have also thought of that while reviewing. So no problems.

Copy link
Contributor

@sidgoyal78 sidgoyal78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@pkuyym pkuyym merged commit 89bbc4f into PaddlePaddle:develop Jan 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants