Skip to content

Fix bug in SetAttrDescVisitor #7165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
QiJune merged 2 commits into from
Jan 3, 2018
Merged

Fix bug in SetAttrDescVisitor #7165

QiJune merged 2 commits into from
Jan 3, 2018

Conversation

@QiJune
Copy link
Member

@QiJune QiJune commented Jan 3, 2018

fix #7162

Following is the protobuf of while operator:

Before fix:

  type: "while"
  attrs {
  name: "sub_block"
  type: BLOCK
  b: true
}

After fix:

  type: "while"
  attrs {
  name: "sub_block"
  type: BLOCK
  block_idx: 1
}

@QiJune QiJune requested review from JiayiFeng and reyoung January 3, 2018 08:51
JiayiFeng
JiayiFeng approved these changes Jan 3, 2018
View reviewed changes
Copy link
Collaborator

@JiayiFeng JiayiFeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing!

@QiJune QiJune merged commit 907e6d0 into PaddlePaddle:develop Jan 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JiayiFeng JiayiFeng JiayiFeng approved these changes

@reyoung reyoung Awaiting requested review from reyoung

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SetAttrDescVisitor handles pointer input incorrectly

2 participants

@QiJune @JiayiFeng