[CINN] Add inplace ops order check in build_cinn_pass #72037
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
zyfncg
reviewed
Apr 3, 2025
Comment on lines
642
to
649
| for (const auto& shared_value : shared_inplace_values) { | ||
| inplace_ops_order_.emplace_back(); | ||
| for (size_t i = 0; i < inplace_values_sets.size(); ++i) { | ||
| if (inplace_values_sets[i].count(shared_value)) { | ||
| inplace_ops_order_.back().push_back(inplace_ops[i]); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
这里看起来只考虑了input value的情况，如果是 b = op_(a), c = op_(b)的情况可以处理吗？
There was a problem hiding this comment.
这个目前没办法写出因为 group 合并导致 inplace 顺序改变的 PR，本地测了包含几个 inplace 的 case 测试代码都没问题
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
paddle/fluid/pir/transforms/sub_graph_detector.cc:597
- [nitpick] The lambda get_inplace_root_value stops iterating upon detecting a cycle by breaking the loop. It may improve clarity and maintainability to add a comment explaining the cycle detection and its intended handling.
while (inplace_map.count(root)) {
zyfncg
approved these changes
Apr 11, 2025
YqGe585
pushed a commit
to YqGe585/Paddle
that referenced
this pull request
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
CINN
PR Types
Bug fixes
Description
Pcard-76996