Fix einsum accuracy diff when with contraction dim #74303
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Operator Mechanism
PR Types
Bug fixes
Description
当前einsum op对contraction dim的处理导致了两个问题,一个是非法地址访问,另一个是精度问题。
问题描述如下:A=[b, d],B=[b,1],einsum equation=
"bd,bd->b",其中d在AB中均出现并且输出中消除因此为contraction dim,前向过程首先需要对B广播成[b,d],再执行contraction操作,得到输出[b]。