Skip to content

Conversation

ooooo-create
Copy link
Contributor

@ooooo-create ooooo-create commented Jul 31, 2025

PR Category

Auto Parallel

PR Types

New features

Description

目前在合并的时候,是把最左边的相邻切分合并到第一个维度进行切分,如果第一个维度不够切,就后续就进行复制,现在的处理是遇到输入切多刀的时候,不够切对应 mesh shape 的乘积,就整个维度的切分不保留,进行复制,就算够切多刀其中的一个维度,{{0},{1,2}} 的时候, 0,1 够切最左边的维度,0,1,2 切不了,现在就会是 {{0}, {}}。
拆分和合并的逻辑相同,都是在多刀在最左边的维度,其余复制,还需要考虑 split 切成的维度够不够切和是否能整除。

Copy link

paddle-bot bot commented Jul 31, 2025

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@ooooo-create ooooo-create force-pushed the co_shard_for_reshape branch 3 times, most recently from 512ab0f to e3a415f Compare August 1, 2025 01:16
@ooooo-create ooooo-create force-pushed the co_shard_for_reshape branch from e3a415f to 096843e Compare August 1, 2025 03:35
@ooooo-create ooooo-create changed the title Test [Auto Parallel] Add spmd_rule about sharding on the same tensor dim by many mesh dim for reshape Aug 1, 2025
@codecov-commenter
Copy link

codecov-commenter commented Aug 1, 2025

Codecov Report

❌ Patch coverage is 95.15152% with 8 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (develop@c28e92f). Learn more about missing BASE report.

Files with missing lines Patch % Lines
paddle/phi/infermeta/spmd_rules/dim_trans.cc 97.20% 4 Missing ⚠️
paddle/phi/infermeta/spmd_rules/reshape.cc 78.94% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             develop   #74352   +/-   ##
==========================================
  Coverage           ?   95.15%           
==========================================
  Files              ?        3           
  Lines              ?      165           
  Branches           ?        0           
==========================================
  Hits               ?      157           
  Misses             ?        8           
  Partials           ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ooooo-create ooooo-create force-pushed the co_shard_for_reshape branch from 463d98f to 92c910e Compare August 1, 2025 14:41
@ooooo-create ooooo-create marked this pull request as ready for review August 11, 2025 07:02
@ooooo-create
Copy link
Contributor Author

/re-run all-failed

From00
From00 previously approved these changes Aug 11, 2025
@ooooo-create
Copy link
Contributor Author

/re-run all-failed

@zhiqiu zhiqiu merged commit 09e1fa5 into PaddlePaddle:develop Aug 12, 2025
72 of 73 checks passed
maxiaolong001 pushed a commit to maxiaolong001/Paddle that referenced this pull request Aug 12, 2025
…y many mesh dim for reshape (PaddlePaddle#74352)

* Add spmd_rule about sharding on the same tensor dim by many mesh dim for reshape

* Fix order

* refine code && tests case

* fix typos

* fix typos

* Fix paddle::get usage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants