Skip to content

Conversation

zhanghonggeng
Copy link
Contributor

@zhanghonggeng zhanghonggeng commented Aug 5, 2025

PR Category

User Experience

PR Types

New features

Description

  1. paddle.add:新增默认参数alpha,out。输入映射x:input、y:other。
  2. paddle.Tensor.add:新增默认参数alpha。输入映射y:other。
  3. paddle.Tensor.add_新增默认参数alpha。输入映射y:other。

注:

  1. y不单独支持scalar,后续会统一支持。

pcard-67164

@zhanghonggeng zhanghonggeng force-pushed the op_add branch 2 times, most recently from 3796cbf to eed0fcb Compare August 5, 2025 07:53
@codecov-commenter
Copy link

codecov-commenter commented Aug 5, 2025

Codecov Report

❌ Patch coverage is 87.50000% with 2 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (develop@32069a5). Learn more about missing BASE report.

Files with missing lines Patch % Lines
python/paddle/tensor/math.py 87.50% 2 Missing ⚠️

❌ Your patch status has failed because the patch coverage (87.50%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop   #74420   +/-   ##
==========================================
  Coverage           ?   87.50%           
==========================================
  Files              ?        1           
  Lines              ?       16           
  Branches           ?        0           
==========================================
  Hits               ?       14           
  Misses             ?        2           
  Partials           ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zhanghonggeng zhanghonggeng changed the title update paddle add api [API compatibility] update paddle add api Aug 11, 2025
Copy link
Contributor

@zhwesky2010 zhwesky2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. name参数都统一放到最后面,避免name参数处于参数列表的任意位置
  2. 已知共性问题:类型提升/二元支持scalar,目前不用单API中修改,paconvert也可注释不执行,这个会后续统一支持

@zhanghonggeng
Copy link
Contributor Author

/re-run all-failed

zhwesky2010
zhwesky2010 previously approved these changes Aug 14, 2025
Copy link
Contributor

@zhwesky2010 zhwesky2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhwesky2010 zhwesky2010 requested a review from SigureMo August 14, 2025 11:42
SigureMo
SigureMo previously approved these changes Aug 14, 2025
@zhanghonggeng
Copy link
Contributor Author

/re-run all-failed

@zhanghonggeng zhanghonggeng dismissed stale reviews from SigureMo and zhwesky2010 via b072eef August 15, 2025 08:34
@zhanghonggeng
Copy link
Contributor Author

/re-run all-failed

@zhanghonggeng
Copy link
Contributor Author

/re-run all-failed

Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhanghonggeng
Copy link
Contributor Author

/re-run all-failed

@zhwesky2010 zhwesky2010 merged commit 8ad3c1e into PaddlePaddle:develop Aug 18, 2025
163 of 177 checks passed
Luckycheng222 pushed a commit to Luckycheng222/Paddle that referenced this pull request Aug 25, 2025
* update paddle add api

* update

* update

* update

* test

* update

* update

* fix Api-Benchmark

* update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants