Skip to content

[CINN] Update cinn/runtime/cuda/float16.h#75090

Merged
SigureMo merged 1 commit intoPaddlePaddle:developfrom
feixi21:fix-cuda-float16
Sep 12, 2025
Merged

[CINN] Update cinn/runtime/cuda/float16.h#75090
SigureMo merged 1 commit intoPaddlePaddle:developfrom
feixi21:fix-cuda-float16

Conversation

@feixi21
Copy link
Contributor

@feixi21 feixi21 commented Sep 4, 2025

PR Category

CINN

PR Types

Bug fixes

Description

  • update cinn/runtime/cuda/float16.h

@paddle-bot
Copy link

paddle-bot bot commented Sep 4, 2025

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Sep 4, 2025
@SigureMo SigureMo changed the title [CINN] Update cinn/runtime/cuda/float16.h [CINN] Update cinn/runtime/cuda/float16.h Sep 12, 2025
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

目前 CI Linux build 的逻辑如下

git checkout pr
build_paddle
git checkout develop
build_paddle
git checkout pr

由于目前 develop 里之前合入的逻辑会导致在 cmake 阶段修改 cinn/runtime/cuda/float16.h,会导致 git workspace 变 dirty,因此当有任何 PR 修改了 cinn/runtime/cuda/float16.h 时(如 #75178),在编译完 PR 版本之后,workspace 已经 dirty,此时 checkout 到 develop 就会挂掉,因为有冲突,也就是任何修改了 cinn/runtime/cuda/float16.h 的 PR 都无法合入

本 PR 类似,虽然本 PR 本身 cmake 阶段已经不再修改 cinn/runtime/cuda/float16.h,但在 develop 编译完成后,因为 develop 是有问题的,会修改源码,因此最后无法 checkout 回 PR,故而报错

为保证其余 PR 能合入,且理论上本 PR 不影响逻辑(当前变动后的版本就是 cmake 自动修改的版本),而且其余 CI 都已通过,故 skip build 流水线

后续需要注意 cmake 里避免添加修改源码的操作,类似生成的文件都应该 git ignore 掉,类似问题最近发生不止一次了,#75241 也类似

@SigureMo SigureMo merged commit 5b995f7 into PaddlePaddle:develop Sep 12, 2025
133 of 139 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants