Skip to content

[Custom Device] CUDAExtension Supports Custom Device#76876

Merged
yongqiangma merged 2 commits intoPaddlePaddle:developfrom
YqGe585:extension
Dec 17, 2025
Merged

[Custom Device] CUDAExtension Supports Custom Device#76876
yongqiangma merged 2 commits intoPaddlePaddle:developfrom
YqGe585:extension

Conversation

@YqGe585
Copy link
Member

@YqGe585 YqGe585 commented Dec 12, 2025

PR Category

Custom Device

PR Types

Improvements

Description

[Custom Device] CUDAExtension supports custom device

@paddle-bot
Copy link

paddle-bot bot commented Dec 12, 2025

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@YqGe585 YqGe585 changed the title [Custom Device] CUDAExtension supports custom device [Custom Device] CUDAExtension Supports Custom Device Dec 12, 2025
yongqiangma
yongqiangma previously approved these changes Dec 12, 2025
Copy link
Contributor

@yongqiangma yongqiangma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YqGe585
Copy link
Member Author

YqGe585 commented Dec 12, 2025

/re-run all-failed

@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2025

Codecov Report

❌ Patch coverage is 6.25000% with 15 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (develop@6cb11cb). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...thon/paddle/utils/cpp_extension/extension_utils.py 6.25% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             develop   #76876   +/-   ##
==========================================
  Coverage           ?    6.25%           
==========================================
  Files              ?        1           
  Lines              ?       16           
  Branches           ?        0           
==========================================
  Hits               ?        1           
  Misses             ?       15           
  Partials           ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@YqGe585
Copy link
Member Author

YqGe585 commented Dec 15, 2025

/re-run all-failed

2 similar comments
@YqGe585
Copy link
Member Author

YqGe585 commented Dec 15, 2025

/re-run all-failed

@YqGe585
Copy link
Member Author

YqGe585 commented Dec 15, 2025

/re-run all-failed

@YqGe585
Copy link
Member Author

YqGe585 commented Dec 16, 2025

/re-run all-failed

2 similar comments
@YqGe585
Copy link
Member Author

YqGe585 commented Dec 16, 2025

/re-run all-failed

@YqGe585
Copy link
Member Author

YqGe585 commented Dec 16, 2025

/re-run all-failed

const std::shared_ptr<Allocation>& allocation);

#if defined(PADDLE_WITH_CUDA) || defined(PADDLE_WITH_HIP)
#if (defined(PADDLE_WITH_CUDA) || defined(PADDLE_WITH_HIP)) && \
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

因为类CUDA硬件需要同时打开PADDLE_WITH_CUDA和PADDLE_WITH_CUSTOM_DEVICE,导致Release跟后面78行的重复声明了。这里关掉一个。

Copy link
Collaborator

@sneaxiy sneaxiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for coverage. Due to custom device.

@YqGe585
Copy link
Member Author

YqGe585 commented Dec 17, 2025

/re-run all-failed

@yongqiangma yongqiangma merged commit 4341ab6 into PaddlePaddle:develop Dec 17, 2025
122 of 140 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants