Skip to content

Clipping bbox in the mAP evaluator calculation. #8872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
qingqing01 merged 1 commit into from
Mar 8, 2018
Merged

Clipping bbox in the mAP evaluator calculation. #8872

qingqing01 merged 1 commit into from
Mar 8, 2018

Conversation

@qingqing01
Copy link
Contributor

@qingqing01 qingqing01 commented Mar 8, 2018

Fix #8871

@qingqing01 qingqing01 requested review from pkuyym and wanghaox March 8, 2018 07:39
pkuyym
pkuyym reviewed Mar 8, 2018
View reviewed changes
paddle/fluid/operators/detection_map_op.h Outdated
Copy link
Contributor

@pkuyym pkuyym Mar 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clip_bbox --> clipped_bbox

Copy link
Contributor Author

@qingqing01 qingqing01 Mar 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Thanks!

paddle/fluid/operators/detection_map_op.h Outdated
Copy link
Contributor

@pkuyym pkuyym Mar 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or you can pass Box& clipped_bbox

Copy link
Contributor Author

@qingqing01 qingqing01 Mar 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not change it. Thanks!

pkuyym
pkuyym approved these changes Mar 8, 2018
View reviewed changes
Copy link
Contributor

@pkuyym pkuyym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qingqing01 qingqing01 merged commit ffda2c4 into PaddlePaddle:develop Mar 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pkuyym pkuyym pkuyym approved these changes

@wanghaox wanghaox Awaiting requested review from wanghaox

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@qingqing01 @pkuyym