Skip to content

Conversation

@chengduoZH
Copy link
Contributor

@chengduoZH chengduoZH commented Mar 9, 2018

related issue #8933
dependent on #8932

@chengduoZH chengduoZH requested a review from jacquesqiao March 9, 2018 12:30
@chengduoZH chengduoZH changed the title [WIP] Enhance regularizer.py Enhance regularizer.py Mar 9, 2018
abhinavarora
abhinavarora previously approved these changes Mar 13, 2018
Copy link
Contributor

@abhinavarora abhinavarora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

dtype="float32", shape=param.shape, lod_level=param.lod_level)

if grad.type == core.VarDesc.VarType.SELECTED_ROWS:
# add concat_rows
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rm this line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@chengduoZH chengduoZH force-pushed the feature/Enhance_regularizer_py branch from 7bd58ff to 93107ce Compare March 14, 2018 02:46
Copy link
Member

@jacquesqiao jacquesqiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chengduoZH chengduoZH merged commit 5a159f3 into PaddlePaddle:develop Mar 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants