Better timeline #9037
Better timeline #9037
Conversation
panyx0718
commented
Mar 14, 2018
panyx0718
commented
- Supported nested event
- Better support for cpu multi-thread
- Betters support nested block and block total time.
|
|
panyx0718
force-pushed
the
develop
branch
8 times, most recently
from
b97dc69 to
fbe8a9a
Compare
| RecordThread::~RecordThread() { | ||
| if (g_state == ProfilerState::kDisabled) return; | ||
| ClearCurThread(); | ||
| } |
There was a problem hiding this comment.
It seems that RecordThread only supports one layer nesting. If RecordThread records the PreThread before setting CurThread, RecordThread can support more layers nesting.
thread0
thread1
thread2
thread1
thread0
There was a problem hiding this comment.
Yes, currently, it doesn't auto support thread nesting. See comments here:
paddle/fluid/platform/device_tracer.cc
The main reason is that we don't have nest threading yet.
Actually, user can add code to give nested thread different ids:
int nested_thread_id = CurThread() * 10 + 1
std::thread([nested_thread_id]() {
RecordThread(nested_thread_id);
...
}
| namespace { | ||
| // block id starts from 0. This id is used to represent the codeblock | ||
| // wrapping the first block 0. | ||
| int kProgramId = -1; |
There was a problem hiding this comment.
Is kProgramId to distinguish the different program in a model?
There was a problem hiding this comment.
No. The global block has block id 0. However, before the block 0 starts, there are some other preprocessing and post-processing overhead. I wrap those codes into block id -1.
chengduoZH
left a comment
chengduoZH
left a comment
There was a problem hiding this comment.
LGTM! We can get this merge first.
3 participants
