Implement Select OP #9088

cs2be · 2018-03-14T22:31:08Z

Initial implementation of select_op, which is inspired by golang http://www.tapirgames.com/blog/golang-concurrent-select-implementation
Create Python API to allow users to access select_op
Create Select unit test in C++
Create Select unit test in Python
Moved Channel utility methods to paddle/fluid/operators/concurrency

…o select

…_op in the cases block and also pull out all channels involved in the select.

…select

…s into the select op

…select

# Conflicts: # paddle/fluid/framework/channel_impl.h

…lect unit test

…utes to select

…RECV or SEND should be executed

…in select op

…back

…annel_util

# Conflicts: # paddle/fluid/framework/channel.h # paddle/fluid/framework/channel_impl.h

abhinavarora

LGTM!

Varun Arora and others added 30 commits March 5, 2018 16:47

Fix old documentation for channel_recv

ea432e2

Initial design of CSP select

f83d824

Redesign channel implementation for Select Op

12ae0ce

Remove unecessary header

2acb1ef

Merge branch 'redesign_channel' of github.com:abhinavarora/Paddle int…

d0f2da4

…o select

Merge branch 'develop' of github.com:PaddlePaddle/Paddle into select

13b0675

Initial checkin of select op, currently will read all the conditional…

dade57c

…_op in the cases block and also pull out all channels involved in the select.

Init python select op API

72f29f5

Merge branch 'select' of https://github.com/abhinavarora/Paddle into …

8fa1548

…select

Python select bug fix when checking op creates block

855c96a

Add case_to_execute as (a) input to select, (b) into the passed input…

c6d2d3c

…s into the select op

Add in addition code for select op

e9285e4

Merge branch 'select' of github.com:abhinavarora/Paddle into select

78c3280

Init fibonacci test from python

b1eacb3

Merge branch 'select' of https://github.com/abhinavarora/Paddle into …

5a73108

…select

implement fibonnaci sequence test

ace0d58

Merge branch 'select' of github.com:abhinavarora/Paddle into select

bc6c7b5

update fib unit test

e63c234

Merge branch 'develop' of github.com:PaddlePaddle/Paddle into select

19b227f

# Conflicts: # paddle/fluid/framework/channel_impl.h

Improve select test cases

e4adacc

Shorten non-pep-8-ed lines

6708136

Add methods on channel needed by select op

7765376

Merge branch 'select' of github.com:abhinavarora/Paddle into select

1704cbb

Fix compile issues, finish implementation, still need to debug code

478a234

Fix issue with fibonncci test, it works now!

7816e89

Change QueueMessage callback to take in an ChannelAction enum, fix se…

7371cf8

…lect unit test

Fix case attributes

0c806ab

Fix issue with select control flow

42a6ef5

Make cases - previously on each selectcase conditional_block - attrib…

c8eaa04

…utes to select

Use class constants for type of channel

59465b1

cs2be and others added 19 commits March 13, 2018 12:17

return boolean from select callback function to tell Channel if this …

2bb95d0

…RECV or SEND should be executed

Improve attributes and inputs comments on select op

4dfb6f5

Fix issues with python unit test

29b4d40

Merge branch 'select' of github.com:abhinavarora/Paddle into select

f26072e

Assert fibonacci final output

bc60a9d

Fix issue when channel name / channel var is null for "default" case …

23318e0

…in select op

Merge branch 'select' of github.com:abhinavarora/Paddle into select

71f7b82

Assert base select test output

0673cf2

Make QueueMessage use shared pointer and modify the order of the call…

b107575

…back

Merge branch 'select' of github.com:abhinavarora/Paddle into select

05e3b28

Fixing the order in which the callback is called

9123b6b

Move channel utility methods to paddle/fluid/operators/concurrency/ch…

41675b0

…annel_util

Create channel_util and move channel util methods

6cb816d

Fix crash when calling select_op

ef41114

Fix deadlock

f0b1d7b

Merge branch 'select' of github.com:abhinavarora/Paddle into select

c838641

Fix issue of channel destructor deadlock

0162530

Fix precommit issues

e000208

Merge branch 'develop' of github.com:PaddlePaddle/Paddle into select

2290a4c

# Conflicts: # paddle/fluid/framework/channel.h # paddle/fluid/framework/channel_impl.h

cs2be requested review from Superjomn, abhinavarora, reyoung, varunarora and wangkuiyi March 14, 2018 22:31

cs2be added 3 commits March 14, 2018 15:33

Accidentally checked in changes to beam_search_op, reverting change.

10a9f67

Fix dependency issue in concurrency cmake

101660b

add device_context dependency for concurrency target

6166dbc

abhinavarora requested a review from chengduoZH March 15, 2018 09:00

abhinavarora approved these changes Mar 15, 2018

View reviewed changes

abhinavarora merged commit 1e4c504 into PaddlePaddle:develop Mar 15, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Implement Select OP #9088

Implement Select OP #9088

Uh oh!

cs2be commented Mar 14, 2018

Uh oh!

abhinavarora left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Implement Select OP #9088

Implement Select OP #9088

Uh oh!

Conversation

cs2be commented Mar 14, 2018

Uh oh!

abhinavarora left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants