Skip to content

Support copy in Fluid channels #9138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abhinavarora merged 2 commits into from
Mar 19, 2018
Merged

Support copy in Fluid channels #9138

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
82dd094
Support copy in Fluid channels
Mar 15, 2018
dd5aa47
Address PR review comments
Mar 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions python/paddle/fluid/concurrency.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ def make_channel(dtype, capacity=0):
return channel


def channel_send(channel, value):
def channel_send(channel, value, copy=False):
"""
Sends a value through a channel variable. Used by an unbuffered or buffered
channel to pass data from within or to a concurrent Go block, where
Expand All @@ -141,6 +141,8 @@ def channel_send(channel, value):
channel (Variable|Channel): Channel variable created using
`make_channel`.
value (Variable): Value to send to channel
copy (bool): Copy data while channel send. If False, then data
is moved. The input cannot be used after move.
Copy link
Contributor

@chengduoZH chengduoZH Mar 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the default value of copy at the end of line145.
Maybe replacing copy with copy_mode is better.

Copy link
Contributor Author

@abhinavarora abhinavarora Mar 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I just realized that I missed your comment and merged the PR. I agree with you. Let me correct it and send you the review separately.

Copy link
Contributor

@chengduoZH chengduoZH Mar 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it doesn't matter, the current scenario for using channel is still less.

Returns:
Variable: The boolean status on whether or not the channel
successfully sent the passed value.
Expand All @@ -162,11 +164,26 @@ def channel_send(channel, value):
type=core.VarDesc.VarType.LOD_TENSOR,
dtype=core.VarDesc.VarType.BOOL)

X = value

if copy is True:
copied_X = helper.create_variable(
name=unique_name.generate(value.name + '_copy'),
type=value.type,
dtype=value.dtype,
shape=value.shape,
lod_level=value.lod_level,
capacity=value.capacity)

assign_op = channel_send_block.append_op(
type="assign_op", inputs={"X": value, }, outputs={"Out": copied_X})
Copy link
Contributor

@cs2be cs2be Mar 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

although this is valid python syntax, I'm wondering if we can remove the extra "," after value

Copy link
Contributor Author

@abhinavarora abhinavarora Mar 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

X = copied_X

channel_send_op = channel_send_block.append_op(
type="channel_send",
inputs={
"Channel": channel,
"X": value,
"X": X,
},
outputs={"Status": status})

Expand Down