Split Executor.Run to Executor.Prepare and Executor.RunPreparedContext for inference #9630
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luotao1
reviewed
Apr 8, 2018
Contributor
luotao1
left a comment
luotao1
left a comment
There was a problem hiding this comment.
可以在第一个comment里面补充一些这个PR的背景么，即为什么要拆分成两个？
paddle/fluid/framework/executor.cc
Outdated
| "'%s' variable should be 'FEED_MINIBATCH' type", | ||
| feed_holder_name); | ||
| if (!feed_holder_name.empty()) { | ||
| // When feed operator are present, so should be feed_holder |
Contributor
There was a problem hiding this comment.
- When feed operators are present
- so should be feed_holder缺少主语？
Contributor
Author
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
|
|
||
| executor.Run(*inference_program, scope, feed_targets, fetch_targets); | ||
| if (PrepareContext) { | ||
| // Note: if you changed the inference_program, you need to call |
Xreki
force-pushed
the
core_inference_prepare
branch
from
31516c8 to
449bdde
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #9000, the basic
Executor.Runwas split into two low-level functions,Executor.PrepareandExecutor.RunPreparedContext. InExecutor.Prepare, operators are created in advance and saved in aExecutorPrepareContext. We can always callExecutor.RunPreparedContextto use theExecutorPrepareContextinstead to avoid frequently creating and destroying of operators if there is no change to the program.For inference, a high level Executor.Run is defined for direct use in C++ inference codes. We should also provide a corresponding high level
Executor.RunPreparedContextif users want to avoid the cost of frequently creating and destroying of operators.