Skip to content

Remove the use of ARCHIVE_START/END #9844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Xreki merged 4 commits into from
Apr 12, 2018
Merged

Remove the use of ARCHIVE_START/END #9844

Xreki merged 4 commits into from
Apr 12, 2018

Conversation

@Xreki
Copy link
Contributor

@Xreki Xreki commented Apr 11, 2018 •
edited
Loading

@Xreki Xreki added the 预测 原名Inference，包含Capi预测问题等 label Apr 11, 2018
@Xreki Xreki mentioned this pull request Apr 12, 2018
Closed
@Xreki Xreki requested review from luotao1 and wangkuiyi April 12, 2018 02:41
luotao1
luotao1 approved these changes Apr 12, 2018
View reviewed changes
Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Some typo could be fixed in next PR.

cmake/cblas.cmake
/usr/lib/reference/
)
else()
# Diable the finding of reference cblas under host's system path
Copy link
Contributor

@luotao1 luotao1 Apr 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diable->Disable

paddle/fluid/inference/io.cc
namespace paddle {
namespace inference {

// Temporarilly add this function for exposing framework::InitDevices() when
Copy link
Contributor

@luotao1 luotao1 Apr 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Temporarilly->Temporarily

@Xreki
Copy link
Contributor Author

Xreki commented Apr 12, 2018

@luotao1 Thanks. Will change the typo in next PR.

@Xreki Xreki merged commit e90e7ab into PaddlePaddle:develop Apr 12, 2018
@Xreki Xreki deleted the core_inference_no_archive branch November 14, 2018 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@luotao1 luotao1 luotao1 approved these changes

@wangkuiyi wangkuiyi Awaiting requested review from wangkuiyi

Assignees

No one assigned

Labels

预测 原名Inference，包含Capi预测问题等

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Why use ARCHIVE_START and ARCHIVE_END in Fluid fatal error: snappy.h: No such file or directory

2 participants

@Xreki @luotao1