【PaddleSpeech No.5】 #4042
Merged
【PaddleSpeech No.5】 #4042
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…EAMDE.md修改：补充 stage 参数说明，明确 vocoder 选择逻辑
|
Thanks for your contribution! |
|
@zxcd pls review |
zxcd
reviewed
Apr 7, 2025
| ./run.sh --stage 3 --stop-stage 3 --gpus 0 | ||
| ``` | ||
| `stage 3` of `run.sh` calls `local/synthesize_e2e.sh`. | ||
| `stage 3` of `run.sh` calls `local/synthesize_e2e.sh`, `stage 0` of it is **Speech cross language from en to zh** and `stage 1` of it is **Speech cross language from zh to en**. |
There was a problem hiding this comment.
this part we have two stages in run.sh and synthesize_e2e.sh, the description need to be clearer
|
@zxcd pls review |
zxcd
reviewed
Apr 14, 2025
| ./run.sh --stage 3 --stop-stage 3 --gpus 0 | ||
| ``` | ||
| `stage 3` of `run.sh` calls `local/synthesize_e2e.sh`. | ||
| `run.sh`'s `stage 3` invokes `synthesize_e2e.sh` and uses the `--stage` to select the specific task for end-to-end speech synthesis. By default, `synthesize_e2e.sh` executes `stage 0`, which performs cross-language speech synthesis from en to zh. To switch to cross-language speech synthesis from zh to en, you can use the `--stage 1` . |
There was a problem hiding this comment.
default include both en-zh and zh-en?
There was a problem hiding this comment.
这段文字感觉可以描述的更清晰点，这里下面描述的参数都是synthesize_e2e.sh中包含的，这里是否可以不出现run.sh的使用介绍，直接介绍synthesize_e2e.sh呢？
类似这个文件的 Synthesizing 部分，直接介绍一下synthesize_e2e.sh 是否会更加清晰？
There was a problem hiding this comment.
`stage 3` of `run.sh` calls `local/synthesize_e2e.sh`.
我觉得第一句这个可以保留？说明 stage3 是调用 synthesize_e2e ，后面的一大串都是对 synthesize_e2e 的详细解释，会不会好一些
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
run.sh and README.md
Describe
run.sh中synthesize的vocoder是hifigan，synthesize_e2e的stage控制中文与英文的互相转换。在README.md中也进行相应补充。
#3997