Skip to content

Add watch group name reg #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jetfuel merged 8 commits into from
Feb 22, 2018
Merged

Add watch group name reg #273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6f4070e
Add vuetify framework
jetfuel Feb 9, 2018
dc75684
use name as key.
jetfuel Feb 9, 2018
86b4424
Merge branch 'migrateFromSanToVue' of github.com:PaddlePaddle/VisualD…
jetfuel Feb 9, 2018
a0091bd
Merge branch 'migrateFromSanToVue' of github.com:PaddlePaddle/VisualD…
jetfuel Feb 9, 2018
a675c1c
Merge branch 'migrateFromSanToVue' of github.com:PaddlePaddle/VisualD…
jetfuel Feb 21, 2018
f4b847c
Merge branch 'migrateFromSanToVue' of github.com:PaddlePaddle/VisualD…
jetfuel Feb 22, 2018
f3c0d16
Merge branch 'migrateFromSanToVue' of github.com:PaddlePaddle/VisualD…
jetfuel Feb 22, 2018
073fdef
Add Watch on the groupNameReg
jetfuel Feb 22, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions frontend/src/images/Images.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,14 +134,15 @@ export default {
this.runsArray = data;
this.config.runs = data;
});

// TODO: Migrate this line from San to Vue
// need debounce， can't use computed
//this.watch('config.groupNameReg', debounce(this.filterTagsList, 300));
},
mounted() {
autoAdjustHeight();
},
watch: {
'config.groupNameReg': function(val) {
this.throttledFilterTagsList()
}
},
methods:{
filterTagsList(groupNameReg) {
if (!groupNameReg) {
Expand All @@ -151,7 +152,12 @@ export default {
let tagsList = this.tagsList || [];
let regExp = new RegExp(groupNameReg);
this.filteredTagsList = tagsList.filter(item => regExp.test(item.tag));
}
},
throttledFilterTagsList: _.debounce(
function() {
this.filterTagsList(this.config.groupNameReg)
}, 300
),
}
};

Expand Down
15 changes: 11 additions & 4 deletions frontend/src/scalars/Scalars.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,13 +142,15 @@ export default {
this.runsArray = data;
this.config.runs = data;
});

// TODO: Migrate this line from San to Vue
//this.watch('config.groupNameReg', debounce(this.filterTagsList, 300));
},
mounted() {
autoAdjustHeight();
},
watch: {
'config.groupNameReg': function(val) {
this.throttledFilterTagsList()
}
},
methods: {
filterTagsList(groupNameReg) {
if (!groupNameReg) {
Expand All @@ -158,7 +160,12 @@ export default {
let tagsList = this.tagsList || [];
let regExp = new RegExp(groupNameReg);
this.filteredTagsList = tagsList.filter(item => regExp.test(item.tag));
}
},
throttledFilterTagsList: _.debounce(
function() {
this.filterTagsList(this.config.groupNameReg)
}, 300
),
}
};

Expand Down