Skip to content

Fix the incorrect pagination issue. #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jetfuel merged 1 commit into from
Feb 22, 2018
Merged

Fix the incorrect pagination issue. #276

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions frontend/src/images/ui/ChartPage.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@
:runsItems="runsItems"
></ui-image>

<v-pagination v-if="total > pageSize"
<v-pagination class="visual-dl-sm-pagination"
v-if="total > pageSize"
v-model="currentPage"
:length="total"
:total-visible="pageSize"
:length="pageLength"
></v-pagination>
</ui-expand-panel>
</div>
Expand Down Expand Up @@ -45,13 +45,14 @@ export default {

filteredPageList() {
let list = this.filteredRunsList || [];
let currentPage = this.currentPage;
let pageSize = this.pageSize;
return list.slice((currentPage - 1) * pageSize, currentPage * pageSize);
return list.slice((this.currentPage - 1) * this.pageSize, this.currentPage * this.pageSize);
},
total() {
let list = this.tagList || [];
let list = this.filteredRunsList || [];
return list.length;
},
pageLength() {
return Math.ceil(this.total / this.pageSize)
}
},
data() {
Expand Down
6 changes: 4 additions & 2 deletions frontend/src/scalars/ui/ChartPage.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,7 @@
<v-pagination
v-if="total > pageSize"
v-model="currentPage"
:length="total"
:total-visible="pageSize"
:length="pageLength"
/>
</ui-expand-panel>
</div>
Expand Down Expand Up @@ -56,6 +55,9 @@ export default {
total() {
let tagList = this.tagList || [];
return tagList.length;
},
pageLength() {
return Math.ceil(this.total / this.pageSize)
}
},
data() {
Expand Down