Skip to content

Fix error message on charts #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jetfuel merged 2 commits into from
Feb 24, 2018
Merged

Fix error message on charts #279

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57a3831
Make sure to clear the chart before each use.
jetfuel Feb 23, 2018
810630f
Add key for v-for loop.
jetfuel Feb 23, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion frontend/src/graph/ui/Chart.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,6 @@ export default {
getPluginGraphsGraph().then(({status, data}) => {
if (+status === 0 && data.url) {
this.graphUrl = data.url
console.log("The url: " + this.graphUrl)
this.addDragEventForImg();
}
});
Expand Down
1 change: 1 addition & 0 deletions frontend/src/histogram/Histogram.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
></ui-chart-page>
<ui-chart-page
v-for="item in groupedTags"
:key="item.group"
:config="config"
:runsItems="runsItems"
:tagList="item.tags"
Expand Down
5 changes: 3 additions & 2 deletions frontend/src/histogram/ui/ChartPage.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,9 @@
<ui-expand-panel :info="total" :title="title">
<div class="visual-dl-chart-page-box">
<ui-chart
v-for="tag in filteredPageList"
:tagInfo="tag"
v-for="tagInfo in filteredPageList"
:key="tagInfo.run + tagInfo.tag.displayName"
:tagInfo="tagInfo"
:runs="config.runs"
:chartType="config.chartType"
:running="config.running"
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/histogram/ui/Config.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
></v-text-field>

<v-radio-group label="Histogram mode" v-model="config.chartType" dark>
<v-radio v-for="mode in chartTypeItems"
<v-radio v-for="mode in chartTypeItems" :key="mode.name"
:label="mode.name" :value="mode.value"></v-radio>
</v-radio-group>

Expand Down
1 change: 1 addition & 0 deletions frontend/src/images/ui/ChartPage.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
<ui-image
class="visual-dl-chart-image"
v-for="tagInfo in filteredPageList"
:key="tagInfo.run + tagInfo.tag.displayName"
:tagInfo="tagInfo"
:isActualImageSize="config.isActualImageSize"
:runs="config.runs"
Expand Down
2 changes: 2 additions & 0 deletions frontend/src/scalars/ui/Chart.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,8 @@ export default {
this.setChartHorizon();
},
tagInfo: function(val) {
// Should Clean up the chart before each use.
this.myChart.clear();
this.setChartsOptions(val);
this.getOriginChartData(val);
}
Expand Down
5 changes: 3 additions & 2 deletions frontend/src/scalars/ui/ChartPage.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,9 @@
<ui-expand-panel :info="tagList.length" :title="title">
<div ref="chartPageBox" class="visual-dl-chart-page-box">
<ui-chart
v-for="tag in filteredTagList"
:tagInfo="tag"
v-for="tagInfo in filteredTagList"
:tagInfo="tagInfo"
:key="tagInfo.run + tagInfo.tag.displayName"
:groupNameReg="config.groupNameReg"
:smoothing="config.smoothing"
:horizontal="config.horizontal"
Expand Down