Skip to content

Update the NODE_ENV variable. #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jetfuel merged 2 commits into from
Mar 12, 2018
Merged

Update the NODE_ENV variable. #310

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7043d47
Update the NODE_ENV variable.
jetfuel Mar 12, 2018
fe6f4e2
Merge branch 'develop' into updateBuildScripts
jetfuel Mar 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,13 @@ check_duplicated() {

build_frontend() {
cd $FRONTEND_DIR
if [ ! -d "dist" ]; then
npm install
npm run build
fi
# # Should always rebuild the dist files.
# if [ ! -d "dist" ]; then
# npm install
# npm run build
# fi
npm install
npm run build
for file_name in "manifest.*.js" "index.*.js" "vendor.*.js"; do
echo $file_name
check_duplicated $file_name
Expand Down
2 changes: 1 addition & 1 deletion frontend/tool/webpack.prod.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ module.exports = merge(baseWebpackConfig, {
plugins: [
new webpack.DefinePlugin({
'process.env': {
'NODE_ENV': 'production'
NODE_ENV: '"production"'
Copy link

@varunarora varunarora Mar 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I hate this guy. Every version of webpack requires this to be done differently. Glad you found the right way

Copy link
Contributor

@nickyfantasy nickyfantasy Mar 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so the one 'NODE_ENV': '"dev"' in webpack.dev.config.js is it ok?

Copy link
Collaborator Author

@jetfuel jetfuel Mar 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that should be fine. We can always develop with Vue without trouble. It is the prod environment having issues.

}
}),

Expand Down