Skip to content

Conversation

@nickyfantasy
Copy link
Contributor

@nickyfantasy nickyfantasy commented Mar 14, 2018

…. Tooltip sorting does not work because string mismatching.

Fixing #321

…. Tooltip sorting does not work because string mismatching.
@nickyfantasy nickyfantasy requested a review from jetfuel March 14, 2018 23:42
Copy link
Collaborator

@jetfuel jetfuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

let sortedPoints;
switch (sortingMethod) {
case 'desc':
case 'descending':
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were we using the wrong strings? yikes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ya

@nickyfantasy nickyfantasy merged commit 2a663b7 into PaddlePaddle:develop Mar 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants