Skip to content

Conversation

@daming-lu
Copy link
Collaborator

@daming-lu daming-lu commented Apr 3, 2018

img_3206

jetfuel
jetfuel previously approved these changes Apr 4, 2018
Copy link
Collaborator

@jetfuel jetfuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mounted() {
this.getOriginChartsData();
let that = this;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we give it a more meaningful name? that seems confusing.

@daming-lu daming-lu merged commit 4a0511d into PaddlePaddle:develop Apr 4, 2018
@daming-lu daming-lu deleted the compound_node branch April 5, 2018 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants