Skip to content

Conversation

@daming-lu
Copy link
Collaborator

Manually add the library to our repo to prevent npm install bug about 'require'

@jetfuel
Copy link
Collaborator

jetfuel commented Apr 4, 2018

@daming-lu You will need to run pre-commit. And the test is failing.

Copy link
Collaborator

@jetfuel jetfuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daming-lu daming-lu merged commit e4018d1 into PaddlePaddle:develop Apr 4, 2018
@daming-lu daming-lu deleted the fix_dagred3_require_issue branch April 5, 2018 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants