This repository was archived by the owner on Jan 24, 2024. It is now read-only.
Update analysis_kpis.py #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Superjomn
reviewed
May 28, 2018
analysis_kpis.py
Outdated
| for kpi_name in self.analysis_result.keys(): | ||
| is_actived = self.kpis_status[kpi_name] | ||
| log.warn('kpi: %s, actived: %s' % (kpi_name, is_actived)) | ||
| log.warn('****** kpi: %s, actived: %s ******' % (kpi_name, is_actived)) |
Contributor
There was a problem hiding this comment.
too ugly.
弄一个函数，把这些特殊的输出标准化一些，不然那容易一个用5个*，一个用6个*，不标准
包括下面的 !!!!! 看起来会比较奇怪，统一到函数里。
或者用文字前缀，比如 NOTE ... 或者 DANGER ...
Superjomn
reviewed
Jun 14, 2018
analysis_kpis.py
Outdated
| suc = False | ||
| print("kpi: %s change_tate too bigger !!!!!!!!!!" % kpi_name) | ||
| print('min:%s max:%s mean:%s median:%s std:%s change_rate:%s' % | ||
| print("NOTE kpi: %s change_rate too bigger!" % kpi_name) |
Superjomn
approved these changes
Jun 15, 2018
Contributor
Superjomn
left a comment
Superjomn
left a comment
There was a problem hiding this comment.
LGTM
确认 log level = info
Collaborator
Author
|
恩恩， 设置了级别logging.INFO ， test 符合期望 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.