Skip to content

Conversation

@xinghai-sun
Copy link
Contributor

No description provided.

@xinghai-sun xinghai-sun requested a review from pkuyym July 13, 2017 03:12
Copy link
Contributor

@pkuyym pkuyym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost LGTM

import argparse
import soundfile
import json
from paddle.v2.dataset.common import md5file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import paddle.v2.dataset.common.md5file as paddle.md5file be better?

Copy link
Collaborator

@kuke kuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost LGTM

unpack(filepath_real, args.target_dir)
unpack(filepath_text, args.target_dir)
unpack(
os.path.join(args.target_dir, 'CHiME3_isolated_et05_real.zip'),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the two file names here are hardcoded while others are set through variables?

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants