Refine data reader and move data_reader to async_data_reader. #726
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuke
reviewed
Mar 13, 2018
| pass | ||
|
|
||
|
|
||
| class SharedNDArray(object): |
Collaborator
There was a problem hiding this comment.
Please add some comments for this class
| self._is_verify = state[4] | ||
|
|
||
|
|
||
| class SharedMemoryPoolManager(object): |
Collaborator
There was a problem hiding this comment.
Also please add some comments for this class.
| label_t.set(labels.ndarray, place) | ||
| label_t.set_lod([lod.ndarray]) | ||
|
|
||
| test_data_reader.recycle(features, labels, lod) |
Collaborator
There was a problem hiding this comment.
Can we hide the recycle, e.g. move it into the iterator?
Contributor
Author
There was a problem hiding this comment.
I have considered to hide this function, seems not trivial. We can validate the correctness first.
kuke
reviewed
Mar 13, 2018
fluid/DeepASR/data_utils/util.py
Outdated
| self._buf = None | ||
| self._array = np.zeros(1, dtype=np.float32) | ||
| self._inited = False | ||
| self._is_verify = is_verify |
fluid/DeepASR/data_utils/util.py
Outdated
|
|
||
| class SharedNDArray(object): | ||
| """SharedNDArray utilizes shared memory to avoid data serialization when | ||
| object of which shared between different processes. We can reconstruct the |
Collaborator
There was a problem hiding this comment.
object of which ---> data object
between --> among
fluid/DeepASR/data_utils/util.py
Outdated
| Args: | ||
| name (str): Address name of shared memory. | ||
| is_verify (bool): Whether to do validation for writing operation. |
Collaborator
There was a problem hiding this comment.
is_verify --> to_verify
Whether to do validation for writing operation --> Whether to validate the writing operation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #705