Change parallel_do to parallel_executor. #833
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qingqing01
reviewed
Apr 13, 2018
fluid/ocr_recognition/ctc_train.py
Outdated
| add_arg('learning_rate', float, 1.0e-3, "Learning rate.") | ||
| add_arg('l2', float, 0.0004, "L2 regularizer.") | ||
| add_arg('max_clip', float, 10.0, "Max clip threshold.") | ||
| add_arg('min_clip', float, -10.0, "Min clip threshold.") |
Collaborator
There was a problem hiding this comment.
max_clip and min_clip are not removed.
fluid/ocr_recognition/ctc_train.py
Outdated
| add_arg('test_list', str, None, "The list file of training images." | ||
| "None means using the default test_list file of reader.") | ||
| add_arg('num_classes', int, None, "The number of classes." | ||
| "None means using the default num_classes from reader.") |
Collaborator
There was a problem hiding this comment.
如之前线下讨论，一些使用频率低的参数需要去掉。
fluid/ocr_recognition/ctc_train.py
Outdated
| def save_model(args, exe, pass_id, batch_id): | ||
| filename = "model_%05d_%d" % (pass_id, batch_id) | ||
| fluid.io.save_params(exe, dirname=args.save_model_dir, filename=filename) | ||
| print "Saved model to: %s/%s." %(args.save_model_dir, filename) |
Collaborator
There was a problem hiding this comment.
train_one_batch、test、save_model会被其他文件用到吗？如果没有，是不是放在 def train()里好些，这样也可以减少参数的传递，比如args, exe, test_reader等都不用传了。
… parallel_executor And some fix: 1. Remove some arguments 2. Rename 'inference' to 'infer' 3. Refine document
qingqing01
reviewed
Apr 20, 2018
| error_evaluator = fluid.evaluator.EditDistance( | ||
| input=decoded_out, label=casted_label) | ||
|
|
||
| # error_evaluator = None |
fluid/ocr_recognition/ctc_train.py
Outdated
| name='label', shape=[1], dtype='int32', lod_level=1) | ||
| sum_cost, error_evaluator, inference_program, model_average = ctc_train_net( | ||
| images, label, args, num_classes) | ||
| # sys.exit(0) |
qingqing01
approved these changes
Apr 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.