Skip to content
This repository was archived by the owner on Jan 24, 2024. It is now read-only.

Conversation

@Yancey0623
Copy link
Contributor

@Yancey0623 Yancey0623 commented Jun 15, 2018

Fixed #52

@Yancey0623 Yancey0623 requested review from guochaorong and putcn June 15, 2018 03:05
from kpi import LessWorseKpi, GreaterWorseKpi

kpis_specs = {
"speedup": [LessWorseKpi, 0.01],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

嗷嗷, 看chenxi老师这个代码,貌似后边36,39行需要带进去一下~

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, done.

Copy link
Contributor

@guochaorong guochaorong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Yancey0623 Yancey0623 merged commit e93b370 into master Jun 15, 2018
@Yancey0623 Yancey0623 deleted the fix_dist_non branch June 15, 2018 11:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants