upgrade all Apollo packages #5413
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ient 4.0
|
No significant changes currently retry |
Contributor
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (300)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Our Pull Request Approval ProcessThis PR will be reviewed according to our: Your PR may be automatically closed if:
Thanks for contributing! |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
|
FYI This is a tracking page for the major refactoring issues. |
Contributor
|
Please fix the conflicting files |
1 similar comment
Contributor
|
Please fix the conflicting files |
Author
Yes I am working on it. |
Author
|
@palisadoes The codeQL flagging seems to be a false positive as it's flagging for the potential XSS vulnerability for formState.avatarURL which is correctly verified in the sanitizeAvatars function for potential attacks. Same is the case with the second warning for userDetails.avatarURL which is being verified in the sanitizeAvatars function. Also these are not my changes and is pre-existing in the develop branch. How should we proceed here? |
Contributor
|
satyanvm
force-pushed
the
apollo-client-upgrade
branch
from
3d4e181 to
d9a6fb2
Compare
Contributor
|
Please fix the conflicting files |
1 similar comment
Contributor
|
Please fix the conflicting files |
Author
I am working on it, it's mostly done. |
Contributor
|
Please fix the conflicting files |
Contributor
|
Author
@palisadoes The work is mostly done, adding some inline css to app-fixed.module.css for the new css check and some pending translations and some new failing tests for the new added code is pending. I will prioritise this over every other, the other issue I am assigned to - I have raised a PR and some 2-3 test cases suggested by coderabbit is pending which I will complete promptly. I will not take up any other issue till this PR is merged. |
Contributor
|
Please ensure:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This PR upgrades all Apollo packages.
**Issue Number:**4256
Fixes #4256
Snapshots/Videos:
If relevant, did you update the documentation?
Summary
Upgrade all Apollo packages.
#4256
Does this PR introduce a breaking change?
Yes useQuery and useMutation now return data typed as unknown instead of any when no type parameter is provided and requires adding explicit type parameters or type assertions. There is no runtime breaking changes, all changes are TypeScript type level.
Checklist
CodeRabbit AI Review
Test Coverage
Other information
This PR upgrades all Apollo packages.
Have you read the contributing guide?
Yes