Refactor: remaining components with profileavatar - 1 #6226
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -46,6 +46,7 @@ vi.mock('react-i18next', () => ({ | |
| 'users.membershipStatus.member': 'Membership status: Member', | ||
| 'users.membershipStatus.pending': 'Membership status: Pending', | ||
| 'users.membershipStatus.notMember': 'Membership status: Not a member', | ||
| 'profileAvatar.altText': 'Test Org', | ||
| }; | ||
|
|
||
| return translations[key] || key; | ||
|
|
@@ -361,6 +362,15 @@ describe('OrganizationCard', () => { | |
| }, | ||
| }, | ||
| }, | ||
| { | ||
| request: { | ||
| query: ORGANIZATION_LIST, | ||
| variables: {}, | ||
| }, | ||
| result: { | ||
| data: {}, | ||
| }, | ||
| }, | ||
| ]; | ||
|
|
||
| render( | ||
|
|
@@ -574,6 +584,15 @@ describe('OrganizationCard', () => { | |
| }, | ||
| }, | ||
| }, | ||
| { | ||
| request: { | ||
| query: ORGANIZATION_LIST, | ||
| variables: {}, | ||
| }, | ||
| result: { | ||
| data: {}, | ||
| }, | ||
| }, | ||
coderabbitai[bot] marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| ]; | ||
|
|
||
| render( | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -43,7 +43,6 @@ import Button from 'react-bootstrap/Button'; | |
| import { useTranslation } from 'react-i18next'; | ||
| import styles from 'style/app-fixed.module.css'; | ||
| import { Tooltip } from '@mui/material'; | ||
| import { useNavigate } from 'react-router-dom'; | ||
| import { InterfaceOrganizationCardProps } from 'types/OrganizationCard/interface'; | ||
| import { ApolloError, useMutation } from '@apollo/client'; | ||
|
|
@@ -56,6 +55,7 @@ import { ORGANIZATION_LIST } from 'GraphQl/Queries/Queries'; | |
| import { USER_JOINED_ORGANIZATIONS_PG } from 'GraphQl/Queries/OrganizationQueries'; | ||
| import { NotificationToast } from 'components/NotificationToast/NotificationToast'; | ||
| import useLocalStorage from 'utils/useLocalstorage'; | ||
| import { ProfileAvatarDisplay } from 'shared-components/ProfileAvatarDisplay/ProfileAvatarDisplay'; | ||
|
|
||
| export interface InterfaceOrganizationCardPropsPG { | ||
| data: InterfaceOrganizationCardProps; | ||
|
|
@@ -171,22 +171,12 @@ function OrganizationCard({ | |
| <div className={styles.innerContainer} data-cy="orgCardContainer"> | ||
| {/* Container for the organization image */} | ||
| <div className={styles.orgImgContainer}> | ||
| <ProfileAvatarDisplay | ||
| fallbackName={name} | ||
| imageUrl={avatarURL} | ||
| dataTestId="emptyContainerForImage" | ||
| enableEnlarge | ||
| /> | ||
| </div> | ||
| <div className={styles.content}> | ||
| <div> | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹 Nitpick | 🔵 Trivial
Consider testing translated alt text value instead of i18n key.
The test queries for the literal i18n key
'profileAvatar.altText'rather than a translated value. While this works because the mock translation function returns keys for untranslated strings, it tests an implementation detail rather than user-facing behavior.💡 Suggested improvement
Add the translation to the mock and test for the actual translated value:
const mockTImplementation = (key: string) => { const translations: Record<string, string> = { talawaAdminPortal: 'Talawa Admin Portal', adminPortal: 'Admin Portal', menu: 'Menu', plugins: 'Plugins', Dashboard: 'Dashboard', Members: 'Members', Events: 'Events', 'Action Items': 'Action Items', Posts: 'Posts', + 'profileAvatar.altText': 'Organization Avatar', }; return translations[key] || key; };Then update the test:
This makes the test more robust to i18n key refactoring and better reflects actual user experience.
🤖 Prompt for AI Agents