-
-
Notifications
You must be signed in to change notification settings - Fork 564
Open
Labels
dartPull requests that update Dart codePull requests that update Dart codedependenciesPull requests that update a dependency filePull requests that update a dependency filegood first issueGood for newcomersGood for newcomersno-issue-activityNo issue activityNo issue activityrefactorRefactor the code to improve its qualityRefactor the code to improve its qualitysecuritySecurity fixSecurity fixtestTesting applicationTesting applicationunapprovedUnapproved, needs to be triagedUnapproved, needs to be triaged
Description
Problem Statement
Missing golden tests for critical widgets.
Files to Modify / Create (static targets)
- test/goldens/**
- test/goldens/golden_test.dart
Files to Modify / Create (detected for this PR)
-
lib/widgets/member_name_tile.dart -
lib/widgets/organization_list.dart -
lib/widgets/pinned_post.dart -
lib/widgets/pledge_card.dart -
lib/widgets/post_container.dart -
lib/widgets/post_list_widget.dart -
lib/widgets/post_modal.dart -
lib/widgets/post_widget.dart -
lib/widgets/raised_round_edge_button.dart -
lib/widgets/recurrence_dialog.dart
Proposed Solution
Implement within MVVM + Provider + GetIt; avoid large rewrites. Keep changes scoped to the listed files.
Implementation Approach
- Update only the files listed above (<= 10 in this PR).
- Add/adjust tests accordingly; keep CI green.
- If more files are needed, open follow-up PRs.
Acceptance Criteria
- All listed files updated
- Tests added/updated (>= 80% for changed units)
- CI passing
- Docs updated if applicable
Starter Code
Starter Code
// test/goldens/golden_test.dart
import 'package:flutter_test/flutter_test.dart';
import 'package:flutter/material.dart';
Widget themed(Widget c,ThemeMode m)=>MaterialApp(themeMode:m,theme:ThemeData.light(),darkTheme:ThemeData.dark(),home:c);
void main(){
testWidgets('MyWidget golden', (t) async{
await t.pumpWidget(themed(const Placeholder(), ThemeMode.light));
await expectLater(find.byType(Placeholder), matchesGoldenFile('mywidget_light.png'));
});
}Dependencies
- Blocked by: MobileFix - Testing: Golden tests for critical widgets (Part 2 of 4) #3214
- Blocks: MobileFix - Testing: Golden tests for critical widgets (Part 4 of 4) #3216
Phase
P2 - High Impact
Metadata
Metadata
Assignees
Labels
dartPull requests that update Dart codePull requests that update Dart codedependenciesPull requests that update a dependency filePull requests that update a dependency filegood first issueGood for newcomersGood for newcomersno-issue-activityNo issue activityNo issue activityrefactorRefactor the code to improve its qualityRefactor the code to improve its qualitysecuritySecurity fixSecurity fixtestTesting applicationTesting applicationunapprovedUnapproved, needs to be triagedUnapproved, needs to be triaged