-
-
Notifications
You must be signed in to change notification settings - Fork 148
chore: misc styling touch-ups #604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few things I have noticed, which are a bit weird (could also be in the production docs, but could still be useful to fix here):
-
When switching dark/light mode, the project boxes in the hero have a transition effect on them. This might be intended, but it is a bit inconsistent with the rest of the application:
weird-animation.mp4
-
In light mode, hovering over the sites in the navigation bar at the left does not yield any visible highlighting, which is inconsistent to dark mode behavior:
broken-hover.mp4
-
And finally, you cannot scroll down on the nav bar. This might be possible via scroll wheel (I wouldn't know, as my scroll wheel broke when editing moonrise patches), but there neither no scroll bar nor can you scroll down when pressing the middle-mouse button, which is bad for accessibility.
you-cannot-scroll-down.mp4
I don't think this is possible to fix without involving JS logic, since moving the transition to the :hover selector would mean losing the ease out animation on hover out
not sure what browser you're trying it on, but I see a color change on hover on both Firefox and Chrome, albeit faint - bumped up the black tone to be more pronounced |
The scrollbar being gone is now fixed, thanks for that. I can now also notice a faint color change, but it could perhaps be more visible if you also bumped up the font weight a bit. Because it is still very very faint |
Hm, the highlight is still no fully satisfactory I feel. The same also applies for the ToC. Maybe make it almost the same color as when it is selected? Another thing I noticed, which is true for both dark and light mode is that whenhovering over the sections in the nav bar, there is no highlighting. I think it could be nice if we added something about that there too. |
Yeah, the ToC hover looks good now 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, had a look through and everything seems in order. Config highlight probably helps with seeing what has been linked to you - happy for this to be merged at will
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also think it looks good
Uh oh!
There was an error while loading. Please reload this page.