Moved message display to be under /messages #2271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnsimons
commented
Mar 12, 2025
| updateMessageDeleteDate(message); | ||
| await downloadHeadersAndBody(message); | ||
| failedMessage.value = message; | ||
| } catch (err) { |
There was a problem hiding this comment.
Removed this catch; it was just swalling exceptions
johnsimons
commented
Mar 12, 2025
johnsimons
force-pushed
the
john/message_view
branch
from
5e7134d to
c2416b5
Compare
johnsimons
commented
Mar 12, 2025
Comment on lines
+501
to
+502
| heading="Are you sure you want to retry this message?" | ||
| body="Are you sure you want to retry this message?" |
There was a problem hiding this comment.
This looks wrong, I'll fix it in a subsquent PR.
There was a problem hiding this comment.
body could be left empty?
johnsimons
commented
Mar 12, 2025
PhilBastian
approved these changes
Mar 12, 2025
| @@ -0,0 +1,13 @@ | |||
| <script setup lang="ts"> | |||
There was a problem hiding this comment.
from memory, redirect can be configured in the router config directly, rather than having to have a separate component
Comment on lines
+501
to
+502
| heading="Are you sure you want to retry this message?" | ||
| body="Are you sure you want to retry this message?" |
There was a problem hiding this comment.
body could be left empty?
| @@ -96,10 +96,15 @@ const config: RouteItem[] = [ | |||
| { | |||
| path: routeLinks.failedMessage.message.template, | |||
| title: "Message", | |||
| component: () => import("@/components/failedmessages/MessageView.vue"), | |||
| component: () => import("@/components/failedmessages/MessageRedirectForBackwardsCompatibility.vue"), | |||
There was a problem hiding this comment.
i think redirects can be done directly rather than through a component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in preparation for a new "All messages" area.
The goal is to share the same view for successful and failed messages.
This is a first step in this direction.