Code churn on Master

[joshwiens]

• I'm submitting a ...
  [X] question about the decisions made in the repository

@katallaxie

While the enthusiasm is great, just slamming home changes without others having the opportunity to vet those changes kind of defeats the point of community & code review. 30 Commits directly to master, to include those to fix or remove features that shouldn't have landed between 27 Sept & 01 Aug.

It also means that everyone that uses the webpack-starter as a base project has to pick up those changes and merge them into what is usually a modified project, it gets tedious quickly.

I'm suggesting you start delivering changes as complete, tested & vetted sets of work through the standard pull request workflow that everyone else uses thus making the update process less labor intensive and less prone to blowing up peoples forks (which happened to me last week).

Landing your own code is generally frowned upon and for good reason. A second ( or multiple ) sets of eyes is never, ever a bad thing.

//cc @gdi2290

[katallaxie]

This was in my PR #944. Which I had @gdi2290 ask to comment on. The changes were perhaps a bit more complicated; but it was to the final removal of some APIs.

[joshwiens]

Which you then merged yourself

[katallaxie]

Yep, if so this caused you trouble, then I apologize for that. I thought it would be best, as Angular is not final, to keep up with development to be stable or 'more' production ready as soon as possible. Perhaps it would be best to work with the gitflow and create a develop branch.

[joshwiens]

I'm not suggesting adding full gitflow as it usually feels like overkill, even for most of my professional stuff.

What I am suggesting is code not be committed directly to origin/master and rather using a standard pull request workflow where changes are PR'd, reviewed & then merged by a party != the authoring dev.

[katallaxie]

I fully agree on the review, and on the need to have all tests passed (fixed this with 63b2419), but I do not fully agree on the merge itself.