Skip to content

otel spans for cdc.batch: pull/sync/normalize#4314

Merged
serprex merged 1 commit into
mainfrom
otel-batch-span
May 23, 2026
Merged

otel spans for cdc.batch: pull/sync/normalize#4314
serprex merged 1 commit into
mainfrom
otel-batch-span

Conversation

@serprex

@serprex serprex commented May 16, 2026

Copy link
Copy Markdown
Member

No description provided.

@serprex serprex requested a review from a team as a code owner May 16, 2026 03:52
@claude

claude Bot commented May 16, 2026

Copy link
Copy Markdown

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

@codecov

codecov Bot commented May 16, 2026

Copy link
Copy Markdown

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
2229 2 2227 206
View the top 1 failed test(s) by shortest run time
github.com/PeerDB-io/peerdb/flow/e2e::TestGenericBQ/Test_Simple_Flow
Stack Traces | 33.8s run time
=== RUN   TestGenericBQ/Test_Simple_Flow
=== PAUSE TestGenericBQ/Test_Simple_Flow
=== CONT  TestGenericBQ/Test_Simple_Flow
    generic_test.go:125: UNEXPECTED STATUS TIMEOUT STATUS_SNAPSHOT
    bigquery.go:86: begin tearing down postgres schema bq_cci0yc0m_20260523203938
--- FAIL: TestGenericBQ/Test_Simple_Flow (33.84s)
View the full list of 1 ❄️ flaky test(s)
github.com/PeerDB-io/peerdb/flow/e2e::TestGenericBQ

Flake rate in main: 22.86% (Passed 54 times, Failed 16 times)

Stack Traces | 0s run time
=== RUN   TestGenericBQ
=== PAUSE TestGenericBQ
=== CONT  TestGenericBQ
--- FAIL: TestGenericBQ (0.00s)
2026/05/23 20:41:26 INFO Received AWS credentials from peer for connector: ci x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN}
2026/05/23 20:41:26 INFO Received AWS credentials from peer for connector: clickhouse x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN}

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@github-actions

Copy link
Copy Markdown
Contributor

🔄 Flaky Test Detected

Analysis: TestGenericPG/Test_Simple_Flow timed out waiting for STATUS_SNAPSHOT transition on a single matrix shard (mysql-gtid); the recent commit touched BigQuery error classification, unrelated to this Postgres generic flow test, indicating a snapshot-progression timing flake.
Confidence: 0.88

✅ Automatically retrying the workflow

View workflow run

@serprex serprex requested a review from jgao54 May 16, 2026 05:36

@ilidemi ilidemi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great change, covers a good amount of DBI-575 which we can add on top

Comment thread flow/activities/flowable_core.go Outdated
@serprex serprex force-pushed the otel-batch-span branch 2 times, most recently from 2c4a169 to 615d0b8 Compare May 23, 2026 18:17
@github-actions

Copy link
Copy Markdown
Contributor

❌ Test Failure

Analysis: Build fails to compile due to undefined identifier otel_metrics.BatchIdKey referenced in activities/flowable_core.go (lines 296, 297, 731), affecting all matrix jobs — a real code bug, not a flaky test.
Confidence: 0.99

⚠️ This appears to be a real bug - manual intervention needed

View workflow run

@github-actions

Copy link
Copy Markdown
Contributor

❌ Test Failure

Analysis: Real bug: compilation fails with "undefined: otel_metrics.BatchIdKey" referenced from activities/flowable_core.go at multiple lines (226, 235, 296, 733), so tests never ran.
Confidence: 0.98

⚠️ This appears to be a real bug - manual intervention needed

View workflow run

@serprex serprex force-pushed the otel-batch-span branch from 615d0b8 to 8945700 Compare May 23, 2026 19:27
@github-actions

Copy link
Copy Markdown
Contributor

🔄 Flaky Test Detected

Analysis: TestApiPg/TestTotalRowsSyncedByMirror failed due to the catalog Postgres terminating the connection (SQLSTATE 57P01 admin_shutdown) and a follow-on replication-slot-still-active teardown race; the same tests passed in the parallel mysql-gtid and mysql-pos matrix legs of this PR, indicating an infrastructure flake rather than a code bug.
Confidence: 0.9

✅ Automatically retrying the workflow

View workflow run

@serprex serprex force-pushed the otel-batch-span branch 4 times, most recently from 48f3bdc to 916371b Compare May 23, 2026 20:28
@serprex serprex force-pushed the otel-batch-span branch from 916371b to 64aa651 Compare May 23, 2026 20:43
@github-actions

Copy link
Copy Markdown
Contributor

🔄 Flaky Test Detected

Analysis: TestGenericBQ/Test_Simple_Flow timed out during STATUS_SNAPSHOT (1 of 2435 tests failed), matching the codebase's already-documented BigQuery snapshot-phase flakiness and unrelated to the latest commit (a Mongo struct field alignment fix).
Confidence: 0.9

✅ Automatically retrying the workflow

View workflow run

@github-actions

Copy link
Copy Markdown
Contributor

🔄 Flaky Test Detected

Analysis: TestApiPg/TestQRep failed with SQLSTATE 57P01 ("terminating connection due to administrator command") — a connection-level Postgres shutdown that only hit the maria matrix entry while mysql-pos/mysql-gtid passed, characteristic of infrastructure flakiness rather than a real bug.
Confidence: 0.85

✅ Automatically retrying the workflow

View workflow run

@serprex serprex merged commit 7197191 into main May 23, 2026
16 of 17 checks passed
@serprex serprex deleted the otel-batch-span branch May 23, 2026 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants