Skip to content

Revert "Revert workaround fixed ClickHouse regression" #4346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pfcoperez merged 1 commit into from
May 25, 2026
Merged

Revert "Revert workaround fixed ClickHouse regression" #4346

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions flow/e2e/clickhouse_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2643,10 +2643,28 @@ func (s ClickHouseSuite) Test_NullEngine() {
require.NoError(s.t, err)
require.NoError(s.t, ch.Exec(s.t.Context(), "TRUNCATE TABLE nulltarget"))
require.NoError(s.t, ch.Close())
// TODO: Revert this block after future CH behaviour is clarified.
// Work around CH 26.5+ behavior: EXCHANGE TABLES and CREATE OR REPLACE on a source table
// orphan its dependent materialized views.
require.NoError(s.t, s.source.Exec(s.t.Context(), `TRUNCATE TABLE `+srcFullName))
// end of workaround block

flowConnConfig.DoInitialSnapshot = true
flowConnConfig.Resync = true
env = ExecutePeerflow(s.t, tc, flowConnConfig)
SetupCDCFlowStatusQuery(s.t, env, flowConnConfig)

// TODO: Revert this block after future CH behaviour is clarified.
// Work around CH 26.5+ behavior: EXCHANGE TABLES and CREATE OR REPLACE on a source table
// orphan its dependent materialized views.
ch, err = connclickhouse.Connect(s.t.Context(), nil, chPeer)
require.NoError(s.t, err)
require.NoError(s.t, ch.Exec(s.t.Context(), `DROP VIEW IF EXISTS nullmv`))
require.NoError(s.t, ch.Exec(s.t.Context(),
`create materialized view nullmv to nulltarget as select id, "key", _peerdb_is_deleted from test_nullengine`))
require.NoError(s.t, ch.Close())
// end of workaround block

EnvWaitForEqualTablesWithNames(env, s, "waiting on initial", srcTableName, "nulltarget", "id,\"key\"")

require.NoError(s.t, s.source.Exec(s.t.Context(),
Expand Down
Loading