error classification: classify a transient mysql error#4362
Merged
Conversation
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
b4c7817 to
dbeb9e7
Compare
❌ 2 Tests Failed:
View the top 2 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Contributor
🔄 Flaky Test DetectedAnalysis: TestGenericPG/Test_Inheritance_Table_Without_Dynamic_Setting timed out waiting for CDC status to transition past STATUS_SNAPSHOT — a PostgreSQL CDC test unrelated to this PR's MySQL error-classification changes, and only one of three matrix jobs failed, indicating a flaky snapshot timeout under high test concurrency. ✅ Automatically retrying the workflow |
dbeb9e7 to
9db8572
Compare
9db8572 to
d925196
Compare
ilidemi
approved these changes
Jun 1, 2026
| if mysql.ErrorEqual(err, mysql.ErrBadConn) || exceptions.InvalidSequenceRe.MatchString(err.Error()) { | ||
| if mysql.ErrorEqual(err, mysql.ErrBadConn) || | ||
| exceptions.InvalidSequenceRe.MatchString(err.Error()) || | ||
| exceptions.InvalidCompressedSequenceRe.MatchString(err.Error()) { |
Contributor
There was a problem hiding this comment.
Just from the verbosity standpoint, should we merge the two regexes?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MySQLStreamingErrortoMySQLExecuteErrorto be more general (this coversExecute,ExecuteSelectStreaming, as well errors coming fromsyncer.StartSyncandsyncer.StartSyncGTID), basically upstream execution protocol related errorsinvalid compressed sequenceerror retryable (both at the query level, and at the error classification level, in case the states in the existing conn is broken and recreating the connector is required)ExecuteandExecuteSelectStreamingin mysql.go returnMySQLExecuteError, instead of having to wrap it at every caller.Fixes: DBI-769