Explicitly specify PG client protocol#4467
Merged
Merged
Conversation
With this, it's safe to unpin `jackc/pgx` dependency and bump its version
masterashu
approved these changes
Jun 22, 2026
❌ 2 Tests Failed:
View the top 2 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Contributor
❌ Test FailureAnalysis: Deterministic failure in TestStringDataTypes/macaddr reproduced identically across all three matrix jobs: switching to the binary PG client protocol (the PR's purpose) makes macaddr decode as raw 6 bytes instead of canonical text, so it's a real bug, not flaky. |
Member
Author
|
Interesting, even fixing the protocol leads to changes at: Taking a peek. |
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this, it's safe to unpin
jackc/pgxdependency and bump its version which is also done in the same PR.The selected protocol version is
3.0which is he one we were selecting by default values with the pinned version:https://github.com/jackc/pgx/blob/4e4eaedb47b7b3cfba0a1b0a9e6a3f015764f046/pgconn/config.go#L472-L474
With the dependency update, the way of decoding macaddr fields is updated to more recent client library versions, concretely after: jackc/pgx@08c9bb1
According to that change, it was a bug to rely on Stringer representation for composite types as macaddr.
The changes in this PR do precisely that, move back to using the stringer interface in the type conversion: e4b97ab