Repository navigation
Update dockerfile dependencies #5006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
| @@ -1,6 +1,6 @@ | ||||||||
| # syntax=docker/dockerfile:1.28@sha256:bb22d9815c728170f72750f4e5b0d672e06176142e1d602c7e66c050100b7e5b | ||||||||
|
|
||||||||
| FROM golang:1.27-alpine@sha256:8a5910f31396cd4d89662f56c68b3ae31d374308270a1c3bd96672ee5ed43414 AS builder | ||||||||
| FROM golang:1.27-alpine@sha256:d200d2dd76b03a99b52651fd1325aff7dcd35422c35c01bac56571b0507f3deb AS builder | ||||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not a pure digest refresh — this moves the Go toolchain 1.27.1 → 1.27.3.
Upstream range (docker-library/golang commit log + Go release history):
No API or behavioural change beyond the x509 denylist, so no regression risk I can see for flow. It also closes an existing drift: CI already pins There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Dep-bump review — What the range contains:
Not a reason to block — it is the intended security fix, and No other regressions identified in the range for how this repo uses the toolchain ( There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This digest bump is not a pure base-image refresh — it moves the Go toolchain used to build the shipped Docker Hub tag→digest mapping:
So the bumped range spans two security releases:
No change requested — the bump is desirable, and it also aligns the image builder with CI, which already pins Worth flagging to reviewers, though: the |
||||||||
| # Allow build flags to be passed in at build time, for example debug flags | ||||||||
| ARG DEBUG_BUILD | ||||||||
| ENV DEBUG_BUILD=${DEBUG_BUILD} | ||||||||
|
|
@@ -30,7 +30,7 @@ RUN --mount=type=cache,target="/root/.cache/go-build" if [[ "$DEBUG_BUILD" = "1" | |||||||
| go install github.com/go-delve/delve/cmd/dlv@latest; \ | ||||||||
| fi | ||||||||
|
|
||||||||
| FROM alpine:3.24@sha256:294b683cb724975bec92580e1e685676bd4b50bda910ddb8c51d4cabeaec77e6 AS flow-base | ||||||||
| FROM alpine:3.24@sha256:be2656061b536c1883c4034790e21d0a09c5aaaf51968b89368a3c0371ea2c9a AS flow-base | ||||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Release-note check (not a blocker) — this digest moves Alpine 3.24.2 → 3.24.3. Digest The digest is applied consistently — both occurrences (here and Minor note on the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Alpine 3.24.2 → 3.24.3 (old
Three things I checked that are fine:
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Dep-bump review — Per the 3.21.9 / 3.22.7 / 3.23.7 / 3.24.3 announcement this is a pure patch release with no breaking changes inside the 3.24 series, carrying:
The packages these stages actually install ( Cross-cutting note: the The pinned AWS RDS bundle |
||||||||
| ENV TZ=UTC | ||||||||
| ADD --checksum=sha256:90a6f1a7978a1b1b096dca6c57511ca48d3b8cf052f8e704baf358f34ea2f21b https://truststore.pki.rds.amazonaws.com/global/global-bundle.pem /usr/local/share/ca-certificates/global-aws-rds-bundle.pem | ||||||||
| RUN apk add --no-cache ca-certificates geos && \ | ||||||||
|
|
||||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -41,7 +41,7 @@ RUN --mount=type=cache,target=/usr/local/cargo/registry \ | |
| mkdir -p /root/target && \ | ||
| cp target/${BUILD_MODE}/peerdb-server /root/target/ | ||
|
|
||
| FROM alpine:3.24@sha256:294b683cb724975bec92580e1e685676bd4b50bda910ddb8c51d4cabeaec77e6 | ||
| FROM alpine:3.24@sha256:be2656061b536c1883c4034790e21d0a09c5aaaf51968b89368a3c0371ea2c9a | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same 3.24.2 → 3.24.3 bump as flow.Dockerfile — correct and consistent. Scope caveat on the 13 OpenSSL CVEs this release carries: the Pre-existing, not introduced here, and not a reason to hold this PR — but if the OpenSSL CVEs matter, the cargo-chef builder digest is the pin that actually needs to move. |
||
| ENV TZ=UTC | ||
| RUN apk add --no-cache ca-certificates postgresql-client curl iputils && \ | ||
| adduser -s /bin/sh -D peerdb && \ | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Release-note check (not a blocker) — this digest moves Go 1.27.2 → 1.27.3.
Digest
d200d2dis exactly the currentgolang:1.27.3-alpinemanifest list (pushed 2026-10-27); the previous8a5910fwas a 1.27.2 build. docker-library/golang bumped1.27→1.27.3on 2026-10-20.Go 1.27.3 contains a single security fix, CVE-2026-111943 (golang/go#82345):
crypto/x509.Verifynow filters out any chain that passes through one of eight blocked intermediate CA keys, so such chains are no longer returned to the caller and verification fails.Why this is worth a look for PeerDB specifically: the flow worker makes outbound TLS connections to user-supplied peers (Postgres, MySQL, MongoDB, Snowflake, ClickHouse, Kafka, Elasticsearch, S3). If any of those endpoints presents a chain through one of the blocked intermediates, it will start failing with a certificate-verification error once this image ships, and the upstream issue documents no
GODEBUGopt-out. The CA is deliberately unnamed upstream, so this cannot be pre-verified from here — just something to recognize if peer TLS errors appear post-deploy, rather than diagnosing it as a PeerDB regression.Otherwise the bump is clean: the tag is unchanged (
1.27-alpine),flow/go.modhas notoolchainpin so it simply builds with 1.27.3, and no logging/stdout surface is touched.