Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions stacks/flow.Dockerfile
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# syntax=docker/dockerfile:1.28@sha256:bb22d9815c728170f72750f4e5b0d672e06176142e1d602c7e66c050100b7e5b

FROM golang:1.27-alpine@sha256:8a5910f31396cd4d89662f56c68b3ae31d374308270a1c3bd96672ee5ed43414 AS builder
FROM golang:1.27-alpine@sha256:d200d2dd76b03a99b52651fd1325aff7dcd35422c35c01bac56571b0507f3deb AS builder

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Release-note check (not a blocker) — this digest moves Go 1.27.2 → 1.27.3.

Digest d200d2d is exactly the current golang:1.27.3-alpine manifest list (pushed 2026-10-27); the previous 8a5910f was a 1.27.2 build. docker-library/golang bumped 1.27 → 1.27.3 on 2026-10-20.

Go 1.27.3 contains a single security fix, CVE-2026-111943 (golang/go#82345): crypto/x509.Verify now filters out any chain that passes through one of eight blocked intermediate CA keys, so such chains are no longer returned to the caller and verification fails.

Why this is worth a look for PeerDB specifically: the flow worker makes outbound TLS connections to user-supplied peers (Postgres, MySQL, MongoDB, Snowflake, ClickHouse, Kafka, Elasticsearch, S3). If any of those endpoints presents a chain through one of the blocked intermediates, it will start failing with a certificate-verification error once this image ships, and the upstream issue documents no GODEBUG opt-out. The CA is deliberately unnamed upstream, so this cannot be pre-verified from here — just something to recognize if peer TLS errors appear post-deploy, rather than diagnosing it as a PeerDB regression.

Otherwise the bump is clean: the tag is unchanged (1.27-alpine), flow/go.mod has no toolchain pin so it simply builds with 1.27.3, and no logging/stdout surface is touched.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a pure digest refresh — this moves the Go toolchain 1.27.1 → 1.27.3.

Upstream range (docker-library/golang commit log + Go release history):

  • Go 1.27.2 (2026-10-08) — 15 security backports: cmd/go toolchain and golang.org/fips140 checksum bypass via a malicious GOMODPROXY, crypto/tls, html/template XSS (stale jsCtx at template-literal entry; missing ES2015+ keywords in regexpPrecederKeywords), net/http (http2 transport accepting multiple Content-Length headers), net/textproto, os. Plus compiler, linker, runtime, compress/flate, encoding/json and encoding/json/v2 bug fixes.
  • Go 1.27.3 (2026-10-19) — crypto/x509 only (CVE-2026-111943 / GO-2026-6809). See the trust-store note on the alpine line below.

No API or behavioural change beyond the x509 denylist, so no regression risk I can see for flow. It also closes an existing drift: CI already pins go-version: 1.27.3 in ci.yml, flow.yml, golang-lint.yml, tilt-flow.yml and cleanup.yml, so until now the shipped binary was built with an older toolchain than the one tests ran against.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dep-bump review — golang:1.27-alpine 8a5910f → d200d2d is Go 1.27.1 → 1.27.3. The new digest is the current 1.27.3-alpine (identical to 1.27.3-alpine3.24). The old digest was pinned on 2026-09-30 in #4874, before 1.27.2 shipped, so this crosses two patch releases rather than one.

What the range contains:

⚠️ One behavioral change worth knowing about before merge, since it gets baked into the shipped flow binaries: go1.27.3 makes x509.Certificate.Verify filter out any chain containing one of eight blocklisted intermediate CA keys (the eMudhra intermediates Mozilla added to OneCRL on 2026-10-17). There is no GODEBUG opt-out. PeerDB dials TLS against user-supplied endpoints (Postgres/MySQL/Mongo sources; ClickHouse/Snowflake/Kafka/Elasticsearch destinations), so any peer presenting a chain through one of those intermediates will start failing handshakes once this image rolls out.

Not a reason to block — it is the intended security fix, and .github/workflows/*.yml already builds and tests on go-version 1.27.3, so this merely brings the container builder in line with CI. But it is probably worth a release-note line so support recognizes that failure mode instead of chasing it as a PeerDB regression.

No other regressions identified in the range for how this repo uses the toolchain (flow/go.mod declares go 1.27.0, so there is no language-version interaction).

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This digest bump is not a pure base-image refresh — it moves the Go toolchain used to build the shipped flow binaries from 1.27.1 → 1.27.3. (An earlier review comment on this PR stated the Go version was unchanged; that is incorrect.)

Docker Hub tag→digest mapping:

Digest Resolves to
8a5910f3… (old) golang:1.27.1-alpine3.24, built 2026-09-21
d200d2dd… (new) golang:1.27.3-alpine3.24 = 1.27-alpine, built 2026-10-27

So the bumped range spans two security releases:

  • Go 1.27.2 (2026-10-08) — security fixes to the go command and crypto/tls, html/template, net/http, net/textproto, os.
  • Go 1.27.3 (2026-10-19) — security fix to crypto/x509 (CVE-2026-111943): the verifier now rejects any chain passing through eight eMudhra intermediate CA keys (added to Mozilla OneCRL on 2026-10-17).

No change requested — the bump is desirable, and it also aligns the image builder with CI, which already pins go-version: 1.27.3 across the flow / ci / golang-lint / cleanup / tilt-flow workflows; released images were previously built with an older toolchain than CI tested against.

Worth flagging to reviewers, though: the crypto/x509 change is a user-visible TLS behaviour change in the shipped binaries, not just a build-time detail. Any mirror whose source or destination certificate chains through one of those intermediates will start failing verification once this image ships. Intended security hardening, but it may belong in release notes.

# Allow build flags to be passed in at build time, for example debug flags
ARG DEBUG_BUILD
ENV DEBUG_BUILD=${DEBUG_BUILD}
Expand Down Expand Up @@ -30,7 +30,7 @@ RUN --mount=type=cache,target="/root/.cache/go-build" if [[ "$DEBUG_BUILD" = "1"
go install github.com/go-delve/delve/cmd/dlv@latest; \
fi

FROM alpine:3.24@sha256:294b683cb724975bec92580e1e685676bd4b50bda910ddb8c51d4cabeaec77e6 AS flow-base
FROM alpine:3.24@sha256:be2656061b536c1883c4034790e21d0a09c5aaaf51968b89368a3c0371ea2c9a AS flow-base

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Release-note check (not a blocker) — this digest moves Alpine 3.24.2 → 3.24.3.

Digest be26560 is the current alpine:3.24 / alpine:3.24.3 manifest list (pushed 2026-10-23); 294b683 was 3.24.2 (2026-09-18). Per docker-library/official-images#22559, 3.24.3 is a pure security patch: musl, zlib and OpenSSL fixes plus ca-certificates refreshed to 20261020. No API/ABI breaks in an Alpine patch release.

The digest is applied consistently — both occurrences (here and stacks/peerdb-server.Dockerfile:44) were updated, and no stale alpine:3.24 pins remain anywhere in stacks/.

Minor note on the ca-certificates 20261020 refresh: line 36 does apk add --no-cache ca-certificates at build time, so the trust store already tracked the live 3.24 repo and is not actually gated by this digest pin. Same class of consideration as the Go 1.27.3 crypto/x509 change flagged on line 3.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alpine 3.24.2 → 3.24.3 (old 294b683… = 3.24.2, published 2026-09-18; new be26560… = 3.24.3, published 2026-10-23). Per docker-library/official-images#22559 this is a security point release: musl CVE-2026-107891, zlib CVE-2026-85091, 13 OpenSSL CVEs, and ca-certificates 20261020.

⚠️ One user-visible behavioural change — intended, not a bug, but worth a release note. ca-certificates 20261020 removes emSign Root CA - C1, emSign ECC Root CA - C3 and emSign ECC Root CA - G3 following the eMudhra intermediate key compromise, and the Go 1.27.3 crypto/x509 fix on line 3 adds a denylist for the affected intermediates. Combined, after this bump peer-flow will refuse TLS to any source/destination peer whose chain terminates in an emSign root, surfacing to users as x509: certificate signed by unknown authority. Narrow blast radius, but it is silent until runtime.

Three things I checked that are fine:

  • The known 3.24.3 breakage (ca-certificates-20261020-r0 conflicting with an exact ca-certificates=20260909-r0 pin) only hits Dockerfiles that pin the version. Both Dockerfiles here use unpinned apk add --no-cache ca-certificates, so no impact — consistent with docker-build passing.
  • The AWS RDS bundle added on line 35 is an Amazon root set with its own --checksum, unaffected by the emSign removal.
  • Builder and runtime move to the same Alpine 3.24.3 in this PR, so the CGO geos/musl link between the golang:1.27-alpine builder and this stage stays ABI-consistent. Both alpine:3.24 pins in the repo (here and peerdb-server.Dockerfile:44) were updated together.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dep-bump review — alpine:3.24 294b683 → be26560 is 3.24.2 → 3.24.3. The new digest matches the 3.24.3 tag (pushed 2026-10-23); the old one was 3.24.2. The same digest is updated consistently at stacks/peerdb-server.Dockerfile:44, and no other alpine:3.24 pin exists in the repo, so the bump is complete.

Per the 3.21.9 / 3.22.7 / 3.23.7 / 3.24.3 announcement this is a pure patch release with no breaking changes inside the 3.24 series, carrying:

The packages these stages actually install (ca-certificates + geos here; ca-certificates, postgresql-client, curl, iputils in peerdb-server.Dockerfile) see no ABI or behavior breaks.

Cross-cutting note: the ca-certificates refresh is the same eMudhra distrust as the Go 1.27.3 crypto/x509 change flagged on line 3, and it affects the Go runtime system cert pool in this image. nexus is largely insulated, since postgres-connection and the reqwest / mysql_async clients use rustls with bundled webpki-roots rather than the system store.

The pinned AWS RDS bundle ADD --checksum= is untouched by this PR, as expected. Net: strictly a security patch.

ENV TZ=UTC
ADD --checksum=sha256:90a6f1a7978a1b1b096dca6c57511ca48d3b8cf052f8e704baf358f34ea2f21b https://truststore.pki.rds.amazonaws.com/global/global-bundle.pem /usr/local/share/ca-certificates/global-aws-rds-bundle.pem
RUN apk add --no-cache ca-certificates geos && \
Expand Down
2 changes: 1 addition & 1 deletion stacks/peerdb-server.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ RUN --mount=type=cache,target=/usr/local/cargo/registry \
mkdir -p /root/target && \
cp target/${BUILD_MODE}/peerdb-server /root/target/

FROM alpine:3.24@sha256:294b683cb724975bec92580e1e685676bd4b50bda910ddb8c51d4cabeaec77e6
FROM alpine:3.24@sha256:be2656061b536c1883c4034790e21d0a09c5aaaf51968b89368a3c0371ea2c9a

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same 3.24.2 → 3.24.3 bump as flow.Dockerfile — correct and consistent.

Scope caveat on the 13 OpenSSL CVEs this release carries: the peerdb-server binary itself does not pick them up. The builder stage sets OPENSSL_STATIC=1 and installs openssl-libs-static (lines 13 and 15), so OpenSSL is statically linked from lukemathwalker/cargo-chef:latest-rust-1.99.1-alpine, whose digest this PR does not touch. The runtime bump does fix the OpenSSL used by postgresql-client and curl installed on line 46, and brings in the musl/zlib/ca-certificates fixes.

Pre-existing, not introduced here, and not a reason to hold this PR — but if the OpenSSL CVEs matter, the cargo-chef builder digest is the pin that actually needs to move.

ENV TZ=UTC
RUN apk add --no-cache ca-certificates postgresql-client curl iputils && \
adduser -s /bin/sh -D peerdb && \
Expand Down
2 changes: 1 addition & 1 deletion stacks/peerdb-ui.Dockerfile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# syntax=docker/dockerfile:1.28@sha256:bb22d9815c728170f72750f4e5b0d672e06176142e1d602c7e66c050100b7e5b

# Base stage
FROM node:24.22.1-alpine@sha256:06d7adf3e0ef61a13f1d28682726366f97a15aa1888c934d3ecec86c33918b53 AS base
FROM node:24.22.2-alpine@sha256:8a32c8cf649a49915a66e81e7a609223c708d0adabf288ee3f4077d765542f85 AS base
ENV TZ=UTC
ENV NPM_CONFIG_UPDATE_NOTIFIER=false
RUN apk add --no-cache openssl && \
Expand Down
Loading