Skip to content

Conversation

@tsalo
Copy link
Member

@tsalo tsalo commented Nov 7, 2024

Closes #459.

Changes proposed in this pull request

  • Replace high-resolution anatomical image in ds_ciftis_wf with ASL-resolution reference image from asl_anat_wf.
  • Update variable names and documentation to be clearer.

@tsalo tsalo added the bug Something isn't working label Nov 7, 2024
@tsalo
Copy link
Member Author

tsalo commented Nov 7, 2024

test_003_full should fail initially, raising the error I detected in #459. Once that happens I'll push my fix to make sure it works.

@tsalo
Copy link
Member Author

tsalo commented Nov 7, 2024

It failed, then I pushed my changes, and now it succeeds. Merging now.

@tsalo tsalo merged commit 571fd2f into PennLINC:main Nov 7, 2024
3 checks passed
@tsalo tsalo deleted the fix-cbf-ciftis branch November 7, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CBF CIFTI generation failing

1 participant